| Révision | ef2aa9f3a78403cd4a50b0e7626b010ca0b71627 (tree) |
|---|---|
| l'heure | 2018-06-16 16:52:35 |
| Auteur | Michael Ellerman <mpe@elle...> |
| Commiter | Greg Kroah-Hartman |
crypto: vmx - Remove overly verbose printk from AES init routines
commit 1411b5218adbcf1d45ddb260db5553c52e8d917c upstream.
In the vmx AES init routines we do a printk(KERN_INFO ...) to report
the fallback implementation we're using.
However with a slow console this can significantly affect the speed of
crypto operations. Using 'cryptsetup benchmark' the removal of the
printk() leads to a ~5x speedup for aes-cbc decryption.
So remove them.
Fixes: 8676590a1593 ("crypto: vmx - Adding AES routines for VMX module")
Fixes: 8c755ace357c ("crypto: vmx - Adding CBC routines for VMX module")
Fixes: 4f7f60d312b3 ("crypto: vmx - Adding CTR routines for VMX module")
Fixes: cc333cd68dfa ("crypto: vmx - Adding GHASH routines for VMX module")
Cc: stable@vger.kernel.org # v4.1+
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/crypto/vmx/aes.c (diff) drivers/crypto/vmx/aes_cbc.c (diff) drivers/crypto/vmx/aes_ctr.c (diff) drivers/crypto/vmx/ghash.c (diff)| @@ -53,8 +53,6 @@ static int p8_aes_init(struct crypto_tfm *tfm) | ||
| 53 | 53 | alg, PTR_ERR(fallback)); |
| 54 | 54 | return PTR_ERR(fallback); |
| 55 | 55 | } |
| 56 | - printk(KERN_INFO "Using '%s' as fallback implementation.\n", | |
| 57 | - crypto_tfm_alg_driver_name((struct crypto_tfm *) fallback)); | |
| 58 | 56 | |
| 59 | 57 | crypto_cipher_set_flags(fallback, |
| 60 | 58 | crypto_cipher_get_flags((struct |
| @@ -55,8 +55,6 @@ static int p8_aes_cbc_init(struct crypto_tfm *tfm) | ||
| 55 | 55 | alg, PTR_ERR(fallback)); |
| 56 | 56 | return PTR_ERR(fallback); |
| 57 | 57 | } |
| 58 | - printk(KERN_INFO "Using '%s' as fallback implementation.\n", | |
| 59 | - crypto_tfm_alg_driver_name((struct crypto_tfm *) fallback)); | |
| 60 | 58 | |
| 61 | 59 | crypto_blkcipher_set_flags( |
| 62 | 60 | fallback, |
| @@ -53,8 +53,6 @@ static int p8_aes_ctr_init(struct crypto_tfm *tfm) | ||
| 53 | 53 | alg, PTR_ERR(fallback)); |
| 54 | 54 | return PTR_ERR(fallback); |
| 55 | 55 | } |
| 56 | - printk(KERN_INFO "Using '%s' as fallback implementation.\n", | |
| 57 | - crypto_tfm_alg_driver_name((struct crypto_tfm *) fallback)); | |
| 58 | 56 | |
| 59 | 57 | crypto_blkcipher_set_flags( |
| 60 | 58 | fallback, |
| @@ -64,8 +64,6 @@ static int p8_ghash_init_tfm(struct crypto_tfm *tfm) | ||
| 64 | 64 | alg, PTR_ERR(fallback)); |
| 65 | 65 | return PTR_ERR(fallback); |
| 66 | 66 | } |
| 67 | - printk(KERN_INFO "Using '%s' as fallback implementation.\n", | |
| 68 | - crypto_tfm_alg_driver_name(crypto_shash_tfm(fallback))); | |
| 69 | 67 | |
| 70 | 68 | crypto_shash_set_flags(fallback, |
| 71 | 69 | crypto_shash_get_flags((struct crypto_shash |
Android-x86
Fork