Ticket #42102

Rename "spaceship_travel_time" server setting

Date d'ouverture: 2021-04-29 02:36 Dernière mise à jour: 2022-01-15 22:54

Rapporteur:
Propriétaire:
(Aucun)
Type:
État:
Ouvert
Composant:
Jalon:
Priorité:
5 - moyen
Sévérité:
5 - moyen
Résolution:
Accepted
Fichier:
1

Détails

Rename "spaceship_travel_time" server setting to indicate it's percentage multiplier.

Ticket History (3/6 Histories)

2021-04-29 02:36 Updated by: cazfi
  • New Ticket "Rename "spaceship_travel_time" server setting" created
2021-11-10 10:16 Updated by: cazfi
Commentaire

Now that we have support also for older format (one version back) rulesets, renaming server settings has become more hairy. It's not only the existing, and already robust, system of handling compatibility with old savegames with the old setting name, but now we should consider also old game.ruleset with server settings included.

AFAIK this would be the first time we need to support outdated server setting name from a ruleset, and we would need to write the systems to do it from scratch. As the issue with "spaceship_travel_time" name is not very serious, I'm inclined to postpone this to 3.2, instead of starting to squeeze all of this to 3.1 schedule.

2021-12-12 15:42 Updated by: cazfi
Commentaire

Reply To cazfi

As the issue with "spaceship_travel_time" name is not very serious, I'm inclined to postpone this to 3.2, instead of starting to squeeze all of this to 3.1 schedule.

Writing the code is not going to take much time, but it would be new code introduced to a stabilizing branch. Will do to master only.

2021-12-12 17:01 Updated by: cazfi
Commentaire

setcompat module to be used -> #43394

2022-01-15 22:54 Updated by: cazfi
  • Résolution Update from Aucun to Accepted

Modifier

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Connexion