Metamessage resetted on ruleset load
As metamessage was turned to a server setting in freeciv-3.0, it now gets resetted to default (empty value) when a new ruleset is loaded. That's even when it has been set with the (supposedly backward compatible) dedicated 'metamessage' command, and not via 'set' command interface.
Arguably resetting *any* server operation related settings just when the rules should change is a bug.
Attached is a S3_0 patch that I've applied to cazfi.net server as a quick fix. It might be a sensible starting point.
Attached is the earlier patch with minimal adjustments. I have a feeling that the change is a bit big for resolving a simple problem, but no better solution has been suggested and I consider this one of the most important issues to fix in 3.0.1.
Patch going to master should follow new CodingStyle compound literals recommendation.
- New master version with compound literals used