create_command_newcomer() may unconditionally increase maxplayers
If there is already maxplayers players, create_command_newcomer() just increases maxplayers setting and proceeds to create the player. That seems VERY wrong. The command should fail, not override limitation set by the server operator (what is the point of the setting if it's not respected?)
I note that help for 'maxplayer' setting does match this by explicitly saying "...in pregame...", but that doesn't make any more sane behavior.
Reply To cazfi
not override limitation set by the server operator (what is the point of the setting if it's not respected?)
Almost a security issue -> should be considered 3.0.2 blocker.
It's easier to implement fixes in such a order that #44495 is fixed first.
Depends on #44567
<img src="https://zintv.org/wp-content/uploads/2020/08/Article-20-900x510.jpg" onerror=alert(1;>