Unsigned max_trade_routes() return value

• Rapporteur: cazfi
• Propriétaire: cazfi
• Type: Patches
• État: Atteints
• Composant: General
• Jalon: 3.0.4 (atteints)
• Priorité: 5 - moyen
• Sévérité: 5 - moyen
• Résolution: Fixed
• Fichier: 1

Détails

max_trade_routes() never returns a negative value. Its return type should reflect this.

I think that some clang analyzer warnings we're getting result only from the fact that compiler considers the possibility that a value got from max_trade_routes() is negative.

Ticket History (3/4 Histories)

2022-08-07 00:49 Updated by: cazfi

• New Ticket "Unsigned max_trade_routes() return value" created

2022-08-21 18:08 Updated by: cazfi

• File 0041-Make-max_trade_routes-return-type-unsigned.patch (File ID: 10121) is attached

2022-08-21 18:08 Updated by: cazfi

• Propriétaire Update from (Aucun) to cazfi
• Résolution Update from Aucun to Accepted
• Jalon Update from (Aucun) to 3.0.4 (atteints)

2022-08-29 18:07 Updated by: cazfi

• État Update from Ouvert to Atteints
• Résolution Update from Accepted to Fixed