Ticket #45687

gtk: Dead 'bg' assignment in create_tech_tree()

Date d'ouverture: 2022-09-23 12:22 Dernière mise à jour: 2023-01-03 05:13

Rapporteur:
Propriétaire:
Type:
État:
Atteints
Composant:
Priorité:
5 - moyen
Sévérité:
5 - moyen
Résolution:
Fixed
Fichier:
3

Détails

Clang analyzer warns that create_tech_tree() assignment of 'bg = COLOR_REQTREE_BACKGROUND;' is never used. That's true as following switch sets 'bg' for each possible value of the enum.

It doesn't seem like a terrible idea to have that assignment in place, in case there's ever an illegal enum value (one that the switch won't catch), but maybe we change this regardless, to avoid clang analyzer spam about it?

Ticket History (3/7 Histories)

2022-09-23 12:22 Updated by: cazfi
  • New Ticket "gtk: Dead 'bg' assignment in create_tech_tree()" created
2022-10-11 22:28 Updated by: cazfi
Commentaire

I think #45831 should be resolved first.

2022-12-28 06:55 Updated by: cazfi
  • Propriétaire Update from (Aucun) to cazfi
  • Résolution Update from Aucun to Accepted
  • Jalon Update from (Aucun) to 3.0.6 (atteints)
2023-01-03 05:13 Updated by: cazfi
  • État Update from Ouvert to Atteints
  • Résolution Update from Accepted to Fixed

Modifier

Please login to add comment to this ticket » Connexion