Commit: 16cc7cc04634266d4657b51660e596dd62b25d15 - zandronum-cluster (hg)

This is a fork of Zandronum used on servers hosted by The Sentinels Playground (TSPG), Euroboros (EB), and Down Under Doomers (DUD).

Commit MetaInfo

• Révision: 16cc7cc04634266d4657b51660e596dd62b25d15 (tree)
• l'heure: 2007-09-26 11:53:18
• Auteur: Brad Carney <bmc431@gmai...>
• Commiter: Brad Carney

Message de Log

- Fixed vulnerability that allowed clients to be crashed by another playing saying a very long chat string.

SVN r761 (beta4-2_b)

Change Summary

• modified: docs/Skulltag Version History.txt
• modified: src/chat.cpp
• modified: src/version.h

Modification

diff -r 22c8019af2ba -r 16cc7cc04634 docs/Skulltag Version History.txt
--- a/docs/Skulltag Version History.txt	Tue Sep 25 20:42:49 2007 +0000
+++ b/docs/Skulltag Version History.txt	Wed Sep 26 02:53:18 2007 +0000
@@ -14,7 +14,8 @@
 v0.97d-beta4.2
 --------------
 
-*- 	- Fixed vulnerablity that allowed servers and clients to be crashed be a remote party. [Carnevil]
+*- 	- Fixed vulnerability that allowed servers to be crashed be a remote party. [Carnevil]
+*-	- Fixed vulnerability that allowed clients to be crashed by another playing saying a very long chat string. [Carnevil]
 *- 	- Fixed a crash that would occur frequently in game modes in which the map experiences a map reset at some point (LMS, duel, survival, etc.). [Carnevil]
 -	- Players no longer lose their team affiliation when they die in team LMS. [Carnevil]
 

diff -r 22c8019af2ba -r 16cc7cc04634 src/chat.cpp
--- a/src/chat.cpp	Tue Sep 25 20:42:49 2007 +0000
+++ b/src/chat.cpp	Wed Sep 26 02:53:18 2007 +0000
@@ -378,7 +378,6 @@
 {
 	ULONG	ulChatLevel;
 	char	szChatHeader[64];
-	char	szChatString[256];
 
 	// If ulPlayer == MAXPLAYERS, it is the server talking.
 	if ( ulPlayer == MAXPLAYERS )
@@ -439,7 +438,6 @@
 	if ( show_messages )
 		S_Sound( CHAN_VOICE, gameinfo.chatSound, 1, ATTN_NONE );
 
-	sprintf( szChatString, "%s%s", szChatHeader, pszString );
 	BOTCMD_SetLastChatString( pszString );
 	BOTCMD_SetLastChatPlayer( players[ulPlayer].userinfo.netname );
 

diff -r 22c8019af2ba -r 16cc7cc04634 src/version.h
--- a/src/version.h	Tue Sep 25 20:42:49 2007 +0000
+++ b/src/version.h	Wed Sep 26 02:53:18 2007 +0000
@@ -63,7 +63,8 @@
 // NETGAMEVERSION 003 = 0.97c2
 // NETGAMEVERSION 004 = 0.97c3
 // NETGAMEVERSION 005 = 0.97d-beta4
-#define NETGAMEVERSION 005
+// NETGAMEVERSION 006 = 0.97d-beta4.2
+#define NETGAMEVERSION 006
 
 // Version stored in the ini's [LastRun] section.
 // Bump it if you made some configuration change that you want to