Commit: 9db100fedece81e8774b299341d266b514627026 - amalsyah12 (git)

firtst release

Commit MetaInfo

• Révision: 9db100fedece81e8774b299341d266b514627026 (tree)
• l'heure: 2020-02-17 21:08:52
• Auteur: Kyotaro Horiguchi <horikyota.ntt@gmai...>
• Commiter: Kyotaro Horiguchi

Message de Log

Restore current hint state when returned from non-hinted query planning.

If no hint is given for the current level query, pg_hint_plan_planner
calls the next level of planner after erasing the
current_hint_state. But it forgot to restore the state before the
planning of the rest part of the current-level query. It is
(a-kind-of) broken by the commit 2c73975 and d1a839a but overlooked by
assuming the required side-effect of the fix. Get back the behavior
by restoring current_hint_state after returned from the lower level
planner with unhinted query.

Issue: https://github.com/ossc-db/pg_hint_plan/issues/30
Reported-by: higuchi-daisuke

Change Summary

• modified: expected/ut-A.out
• modified: pg_hint_plan.c

Modification

--- a/expected/ut-A.out
+++ b/expected/ut-A.out
@@ -4260,7 +4260,12 @@ SQL statement "SELECT /*+ IndexScan(t_1) */ nested_planner(cnt - 1)
 	 ORDER BY t_1.c1 LIMIT 1"
 PL/pgSQL function nested_planner(integer) line 12 at SQL statement
 LOG:  pg_hint_plan:
-no hint
+used hint:
+IndexScan(t_1)
+not used hint:
+duplication hint:
+error hint:
+
 CONTEXT:  SQL statement "SELECT /*+ IndexScan(t_1) */ nested_planner(cnt - 1)                 FROM s1.t1 t_1
 	  JOIN s1.t2 t_2 ON (t_1.c1 = t_2.c1)
 	 ORDER BY t_1.c1 LIMIT 1"
@@ -4278,7 +4283,12 @@ SQL statement "SELECT /*+ IndexScan(t_1) */ nested_planner(cnt - 1)
 	 ORDER BY t_1.c1 LIMIT 1"
 PL/pgSQL function nested_planner(integer) line 12 at SQL statement
 LOG:  pg_hint_plan:
-no hint
+used hint:
+IndexScan(t_1)
+not used hint:
+duplication hint:
+error hint:
+
 CONTEXT:  SQL statement "SELECT /*+ IndexScan(t_1) */ nested_planner(cnt - 1)                 FROM s1.t1 t_1
 	  JOIN s1.t2 t_2 ON (t_1.c1 = t_2.c1)
 	 ORDER BY t_1.c1 LIMIT 1"

--- a/pg_hint_plan.c
+++ b/pg_hint_plan.c
@@ -2858,9 +2858,14 @@ standard_planner_proc:
 	}
 	current_hint = NULL;
 	if (prev_planner)
-		return (*prev_planner) (parse, cursorOptions, boundParams);
+		result = (*prev_planner) (parse, cursorOptions, boundParams);
 	else
-		return standard_planner(parse, cursorOptions, boundParams);
+		result = standard_planner(parse, cursorOptions, boundParams);
+
+	if (HintStateStack)
+		current_hint = (HintState *) lfirst(list_head(HintStateStack));
+
+	return result;
 }
 
 /*