susumu.yata
null+****@clear*****
Tue Dec 16 10:43:35 JST 2014
susumu.yata 2014-11-17 17:32:46 +0900 (Mon, 17 Nov 2014) New Revision: 453b22e1305e3e266075c6d4747962ca9d3c49f1 https://github.com/groonga/grnxx/commit/453b22e1305e3e266075c6d4747962ca9d3c49f1 Message: Add TODO comments. Modified files: include/grnxx/data_types/vector/bool.hpp include/grnxx/data_types/vector/float.hpp include/grnxx/data_types/vector/geo_point.hpp include/grnxx/data_types/vector/int.hpp Modified: include/grnxx/data_types/vector/bool.hpp (+2 -0) =================================================================== --- include/grnxx/data_types/vector/bool.hpp 2014-11-17 17:32:18 +0900 (7907d42) +++ include/grnxx/data_types/vector/bool.hpp 2014-11-17 17:32:46 +0900 (4a6f34f) @@ -21,6 +21,8 @@ class Vector<Bool> { constexpr Vector(const Bool *data, size_t size) : data_(data), size_(size) {} explicit constexpr Vector(NA) : data_(nullptr), size_(NA()) {} + // TODO: The argument should be Int. + // Also, N/A should be returned for an invalid "i". const Bool &operator[](size_t i) const { return data_[i]; } Modified: include/grnxx/data_types/vector/float.hpp (+2 -0) =================================================================== --- include/grnxx/data_types/vector/float.hpp 2014-11-17 17:32:18 +0900 (796647e) +++ include/grnxx/data_types/vector/float.hpp 2014-11-17 17:32:46 +0900 (916a923) @@ -23,6 +23,8 @@ class Vector<Float> { size_(size) {} explicit constexpr Vector(NA) : data_(nullptr), size_(NA()) {} + // TODO: The argument should be Int. + // Also, N/A should be returned for an invalid "i". const Float &operator[](size_t i) const { return data_[i]; } Modified: include/grnxx/data_types/vector/geo_point.hpp (+2 -0) =================================================================== --- include/grnxx/data_types/vector/geo_point.hpp 2014-11-17 17:32:18 +0900 (db787e1) +++ include/grnxx/data_types/vector/geo_point.hpp 2014-11-17 17:32:46 +0900 (2014fd1) @@ -23,6 +23,8 @@ class Vector<GeoPoint> { size_(size) {} explicit constexpr Vector(NA) : data_(nullptr), size_(NA()) {} + // TODO: The argument should be Int. + // Also, N/A should be returned for an invalid "i". const GeoPoint &operator[](size_t i) const { return data_[i]; } Modified: include/grnxx/data_types/vector/int.hpp (+2 -0) =================================================================== --- include/grnxx/data_types/vector/int.hpp 2014-11-17 17:32:18 +0900 (d583381) +++ include/grnxx/data_types/vector/int.hpp 2014-11-17 17:32:46 +0900 (dc9b709) @@ -21,6 +21,8 @@ class Vector<Int> { constexpr Vector(const Int *data, size_t size) : data_(data), size_(size) {} explicit constexpr Vector(NA) : data_(nullptr), size_(NA()) {} + // TODO: The argument should be Int. + // Also, N/A should be returned for an invalid "i". const Int &operator[](size_t i) const { return data_[i]; } -------------- next part -------------- HTML����������������������������...Télécharger
