Kenji Okimoto
okimo****@clear*****
Mon Jun 30 10:08:46 JST 2014
(2014年06月29日 01:29), YUKI Hiroshi wrote: > 他動詞としてのjoin/unjoinなので、自動詞のleaveはここでは不適切だと思われ > ます。 類義語としては attach/detach というのもありますね。 http://www.oxforddictionaries.com/definition/english-thesaurus/join?q=join http://www.oxforddictionaries.com/definition/english/unjoin?q=unjoin > > Kouhei Sutou wrote: >> Author >> Kouhei Sutou <kou �� clear-code.com> >> Date >> 2014-06-28 23:38:17 +0900 (Sat, 28 Jun 2014) >> New Revision >> feeca840c99b2233295f508c576361c8efee619d >> <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d> >> Message >> >> Add a TODO comment >> >> Modified files >> >> * lib/droonga/command/serf_event_handler.rb >> <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#diff-0> >> >> Modified: lib/droonga/command/serf_event_handler.rb (+1 -1) >> =================================================================== >> >> ... <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0L70> >> 71 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0L71> >> 72 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0L72> >> 73 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0L73> >> 74 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0L74> >> >> 75 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0L75> >> 76 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0L76> >> 77 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0L77> >> >> >> >> ... <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0R70> >> 71 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0R71> >> 72 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0R72> >> 73 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0R73> >> >> 74 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0R74> >> 75 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0R75> >> 76 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0R76> >> 77 <https://github.com/droonga/droonga-engine/commit/feeca840c99b2233295f508c576361c8efee619d#L0R77> >> >> >> >> @@ -71,7 +71,7 @@ module Droonga >> save_status(:role, @payload["role"]) >> when "join" >> process_node_join >> - when "unjoin" >> + when "unjoin" # TODO: Is "unjoin" clear word? How about "leave"? >> process_node_unjoin >> end >> end >> >> >> >> _______________________________________________ >> Groonga-commit mailing list >> Groonga-commit �� lists.sourceforge.jp >> http://lists.sourceforge.jp/mailman/listinfo/groonga-commit >> > -- Kenji Okimoto <okimoto �� clear-code.com>
