src/player/player-damage.c: missing prototype for get_rnd_line()

• Rapporteur: backwardseric
• Propriétaire: habu
• Type: Patches
• État: Atteints
• Composant: (Aucun)
• Jalon: 変愚蛮怒3.0.0Alpha5リリース (atteints)
• Priorité: 1 - le plus bas
• Sévérité: 1 - le plus bas
• Résolution: Duplicate
• Fichier: Aucun

Détails

The version of src/player/player-damage.c currently in the develop branch calls get_rnd_line() but does not have a prototype for that function. With the default compiler options on clang (at least for version 12), that triggers a compiler error.

This commit, https://osdn.net/projects/hengbandforosx/scm/git/hengbandosx/commits/9e8a2452f24e526c7d51798c480352a07f68707f , (clang-player-damage-missing-prototype branch on the hengbandforosx project; the branch is based off Hengband's develop branch) pulls in io/files-util.h to get the prototype for get_rnd_line().

Ticket History (3/5 Histories)

2021-02-06 06:33 Updated by: backwardseric

• New Ticket "src/player/player-damage.c: missing prototype for get_rnd_line()" created

2021-02-06 06:41 Updated by: backwardseric

Commentaire

I should have specified that the error occurred when reporting the score had been disabled (WORLD_SCORE not set so io/report.h does not include io/files-util.h).

2021-02-06 15:41 Updated by: habu

• État Update from Ouvert to Atteints
• Résolution Update from Aucun to Duplicate

Commentaire

I had noticed this problem some time ago and had created a ticket #41444 for this issue.

Your series of commits (tickets #41480 #41481 #41482) will be taken in and this issue will be dealt with in ticket #41444.

Thank you.

2021-02-06 21:26 Updated by: deskull

• Jalon Update from (Aucun) to 変愚蛮怒3.0.0Alpha5リリース (atteints)

2021-02-06 21:27 Updated by: deskull

• Propriétaire Update from (Aucun) to habu