Fujii Masao
masao****@gmail*****
2013年 10月 1日 (火) 02:20:30 JST
On Mon, Sep 30, 2013 at 12:15 PM, Fujii Masao <masao****@gmail*****> wrote: > On Fri, Sep 27, 2013 at 9:30 PM, Beena Emerson <memis****@gmail*****> wrote: >> >> >> >> Hello, >> >> On Tue, Sep 17, 2013 at 6:49 PM, Fujii Masao <masao****@gmail*****> wrote: >>> >>> On Tue, Sep 17, 2013 at 10:29 PM, Beena Emerson <memis****@gmail*****> >>> wrote: >>> > Hello, >>> > >>> > I am starting this new thread so that the discussion does not get mixed. >>> > >>> > On Tue, Sep 17, 2013 at 5:00 PM, Fujii Masao <masao****@gmail*****> >>> > wrote: >>> >> Should we test whether pg_bigm can co-exist with pg_trgm? I'm not sure >>> >> how to test that, though. Thought? >>> > >>> > I had a thought regarding this so I thought I would share. >>> > >>> > The tests including pg_trgm and pg_bigm will definitely fail if pg_trgm >>> > is >>> > not installed. >>> > >>> > To separate the trgm tests with only bigm tests, I think maybe we can >>> > have a >>> > separate command like installcheck-trgm. which can be run after pg_trgm >>> > is >>> > also installed. >>> >>> Sounds good. >> >> >> Please find attached the patch which uses installcheck-trgm to test if >> pg_bigm and pg_trgm can co-exist. > > Thanks a lot! > >> Two new files are added in the sql folder: >> - init_trgm.sql file loads the pg_trgm module into the database. > > Yep, this is required. I committed this part. Thanks! Regards, -- Fujii Masao
Fork