Record executed plans on PostgreSQL

Fork

Hi,

When I compiled pg_store_plans with PostgreSQL master branch on my MacOS,
I got the following lots of compiler warnings. ISTM that they should be fixed.
Thought?

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -g -O0 -I. -I./ -I/dav/head-pgsql/include/server -I/dav/head-pgsql/include/internal -c -o pg_store_plans.o pg_store_plans.c
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -g -O0 -I. -I./ -I/dav/head-pgsql/include/server -I/dav/head-pgsql/include/internal -c -o pgsp_json.o pgsp_json.c
pgsp_json.c:141:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Result, "a" ,"Result", NULL, false, NULL, NULL},
~^~~~~~~~
pgsp_json.c:142:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_ModifyTable, "b" ,"ModifyTable", NULL, false, NULL, NULL},
~^~~~~~~~~~~~~
pgsp_json.c:143:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Append, "c" ,"Append", NULL, false, NULL, NULL},
~^~~~~~~~
pgsp_json.c:144:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_MergeAppend, "d" ,"Merge Append", NULL, false, NULL, NULL},
~^~~~~~~~~~~~~
pgsp_json.c:145:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_RecursiveUnion,"e" ,"Recursive Union",NULL, false, NULL, NULL},
~^~~~~~~~~~~~~~~~
pgsp_json.c:146:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_BitmapAnd, "f" ,"BitmapAnd", NULL, false, NULL, NULL},
~^~~~~~~~~~~
pgsp_json.c:147:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_BitmapOr, "g" ,"BitmapOr", NULL, false, NULL, NULL},
~^~~~~~~~~~
pgsp_json.c:148:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Scan, "" , "", "", false, NULL, NULL},
~^~~~~~
pgsp_json.c:149:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_SeqScan, "h" ,"Seq Scan", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:150:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_IndexScan, "i" ,"Index Scan", NULL, false, NULL, NULL},
~^~~~~~~~~~~
pgsp_json.c:151:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_IndexOnlyScan,"j","Index Only Scan",NULL, false, NULL, NULL},
~^~~~~~~~~~~~~~~
pgsp_json.c:152:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_BitmapIndexScan,"k" ,"Bitmap Index Scan", NULL, false, NULL, NULL},
~^~~~~~~~~~~~~~~~~
pgsp_json.c:153:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_BitmapHeapScan,"l" ,"Bitmap Heap Scan", NULL ,false, NULL, NULL},
~^~~~~~~~~~~~~~~~
pgsp_json.c:154:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_TidScan, "m" ,"Tid Scan", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:155:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_SubqueryScan,"n" ,"Subquery Scan", NULL, false, NULL, NULL},
~^~~~~~~~~~~~~~
pgsp_json.c:156:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_FunctionScan,"o" ,"Function Scan", NULL, false, NULL, NULL},
~^~~~~~~~~~~~~~
pgsp_json.c:157:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_ValuesScan, "p" ,"Values Scan", NULL, false, NULL, NULL},
~^~~~~~~~~~~~
pgsp_json.c:158:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_CteScan, "q" ,"CTE Scan", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:159:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_WorkTableScan,"r","WorkTable Scan", NULL, false, NULL, NULL},
~^~~~~~~~~~~~~~~
pgsp_json.c:160:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_ForeignScan, "s" , "Foreign Scan", NULL, false, NULL, NULL},
~^~~~~~~~~~~~~
pgsp_json.c:161:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Join, "" , "", NULL, false, NULL, NULL},
~^~~~~~
pgsp_json.c:162:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_NestLoop, "t" ,"Nested Loop", NULL, false, NULL, NULL},
~^~~~~~~~~~
pgsp_json.c:163:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_MergeJoin, "u" ,"Merge Join", "Merge", false, NULL, NULL},
~^~~~~~~~~~~
pgsp_json.c:164:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_HashJoin, "v" ,"Hash Join", "Hash", false, NULL, NULL},
~^~~~~~~~~~
pgsp_json.c:165:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Material, "w" ,"Materialize", NULL, false, NULL, NULL},
~^~~~~~~~~~
pgsp_json.c:166:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Sort, "x" ,"Sort", NULL, false, NULL, NULL},
~^~~~~~
pgsp_json.c:167:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Group, "y" ,"Group", NULL, false, NULL, NULL},
~^~~~~~~
pgsp_json.c:168:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Agg, "z" ,"Aggregate", NULL, false, NULL, NULL},
~^~~~~
pgsp_json.c:169:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_WindowAgg, "0" ,"WindowAgg", NULL, false, NULL, NULL},
~^~~~~~~~~~~
pgsp_json.c:170:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Unique, "1" ,"Unique", NULL, false, NULL, NULL},
~^~~~~~~~
pgsp_json.c:171:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Hash, "2" ,"Hash", NULL, false, NULL, NULL},
~^~~~~~
pgsp_json.c:172:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_SetOp, "3" ,"SetOp", NULL, false, NULL, NULL},
~^~~~~~~
pgsp_json.c:173:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_LockRows, "4" ,"LockRows", NULL, false, NULL, NULL},
~^~~~~~~~~~
pgsp_json.c:174:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Limit, "5" ,"Limit", NULL, false, NULL, NULL},
~^~~~~~~
pgsp_json.c:175:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, NULL, NULL, NULL, false, NULL, NULL}
~^~~~~~~~~
pgsp_json.c:180:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "b" ,"Backward", "Backward", false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:181:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "n" ,"NoMovement","", false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:182:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "f" ,"Forward", "", false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:183:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, NULL , NULL, NULL, false, NULL, NULL}
~^~~~~~~~~
pgsp_json.c:188:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "o" ,"Outer", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:189:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "i" ,"Inner", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:190:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "s" ,"Subquery", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:191:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "m" ,"Member", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:192:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "I" ,"InitPlan", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:193:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "S" ,"SubPlan", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:194:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, NULL, NULL, NULL, false, NULL, NULL}
~^~~~~~~~~
pgsp_json.c:199:3: warning: implicit conversion from enumeration type 'pgsp_strategies' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{S_Plain, "p" ,"Plain", NULL, false, NULL, NULL},
~^~~~~~~
pgsp_json.c:200:3: warning: implicit conversion from enumeration type 'pgsp_strategies' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{S_Sorted, "s" ,"Sorted", NULL, false, NULL, NULL},
~^~~~~~~~
pgsp_json.c:201:3: warning: implicit conversion from enumeration type 'pgsp_strategies' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{S_Hashed, "h" ,"Hashed", NULL, false, NULL, NULL},
~^~~~~~~~
pgsp_json.c:202:3: warning: implicit conversion from enumeration type 'pgsp_strategies' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{S_Invalid, NULL, NULL, NULL, false, NULL, NULL}
~^~~~~~~~~
pgsp_json.c:207:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "i" ,"Insert", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:208:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "d" ,"Delete", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:209:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "u" ,"Update", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:210:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, NULL, NULL, NULL, false, NULL, NULL}
~^~~~~~~~~
pgsp_json.c:215:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "i" ,"Inner", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:216:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "l" ,"Left", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:217:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "f" ,"Full", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:218:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "r" ,"Right", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:219:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "s" ,"Semi", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:220:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "a" ,"Anti", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:221:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, NULL, NULL, NULL, false, NULL, NULL}
~^~~~~~~~~
pgsp_json.c:226:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "i" ,"Intersect", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:227:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "I" ,"Intersect All", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:228:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "e" ,"Except", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:229:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "E" ,"Except All", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:230:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, NULL, NULL, NULL, false, NULL, NULL}
~^~~~~~~~~
pgsp_json.c:235:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "h" ,"top-N heapsort", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:236:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "q" ,"quicksort", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:237:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "e" ,"external sort", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:238:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "E" ,"external merge", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:239:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "s" ,"still in progress", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:240:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, NULL, NULL, NULL, false, NULL, NULL}
~^~~~~~~~~
pgsp_json.c:245:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "d" ,"Disk", NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:246:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, "m" ,"Memory",NULL, false, NULL, NULL},
~^~~~~~~~~
pgsp_json.c:247:3: warning: implicit conversion from enumeration type 'enum NodeTag' to different enumeration type 'pgsp_prop_tags' [-Wenum-conversion]
{T_Invalid, NULL, NULL, NULL, false, NULL, NULL}
~^~~~~~~~~
75 warnings generated.
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -g -O0 -I. -I./ -I/dav/head-pgsql/include/server -I/dav/head-pgsql/include/internal -c -o pgsp_json_text.o pgsp_json_text.c
pgsp_json_text.c:51:22: warning: implicit conversion from enumeration type 'pgsp_prop_tags' to different enumeration type 'NodeTag' (aka 'enum NodeTag') [-Wenum-conversion]
vals->nodetag = p->tag;
~ ~~~^~~
1 warning generated.

Regards,