[Svardos-users] Change pkg command output

Back to archive index
Robert Riebisch rr****@bttr-*****
Tue Dec 27 00:12:39 JST 2022


Hi Mateusz,
hi all,

>> I'd like to change pkg:
>> Show ', X errors' only, if there really was one or more errors.
>> 
>> Reason: Over the years my brain became trained to spot the word 'error'
>> very quickly. In the case of pkg just to see that error count is 0 all
>> the time so far.
> 
> +1

Today I noticed a bug in the "pkg install" command.
Using a manipulated .svp file, "pkg install blocek.svp" displays
"ERROR: failed extracting ...", but later displays:
"Package blocek installed: 122 files extracted, 0 errors."

Cause of "0 errors" is the use of %d instead of %ld in the pkg language
files. (But the comment in pkginst.c is right. :-D)
This could be fixed easily, although I don't want to mess around with
SVN branches (trunk, tags) in the public repo.

But do we need these numbers at all?
Do the numbers really matter for the next steps?
I think, when there's at least one error, a user should grab the package
again and repeat pkg install. Or run chkdsk. Or run Memtest.

I suggest to change the message to just "Package blocek has been installed."
That matches the final "pkg remove <package name>" message.

Cheers,
Robert
-- 
BTTR Software   https://www.bttr-software.de/
DOS ain't dead  https://www.bttr-software.de/forum/



More information about the Svardos-users mailing list
Back to archive index