Commit: 4a9f7d653c089fdd8ca66a51caab7c9687f50cd1 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• Révision: 4a9f7d653c089fdd8ca66a51caab7c9687f50cd1 (tree)
• l'heure: 2018-08-01 22:42:37
• Auteur: Nick Clifton <nickc@redh...>
• Commiter: Nick Clifton

Message de Log

Fix potential illegal memory access in AVR backend.

* elf32-avr.c (avr_stub_name): Check for a NULL return from
bfd_malloc.

Change Summary

• modified: bfd/ChangeLog
• modified: bfd/elf32-avr.c

Modification

--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
[phone]  Nick Clifton  <[e-mail]>
+
+	* elf32-avr.c (avr_stub_name): Check for a NULL return from
+	bfd_malloc.
+
 2018-08-01  Zenith  <[e-mail]>
 
 	PR 23460

--- a/bfd/elf32-avr.c
+++ b/bfd/elf32-avr.c
@@ -3295,10 +3295,10 @@ avr_stub_name (const asection *symbol_section,
 
   len = 8 + 1 + 8 + 1 + 1;
   stub_name = bfd_malloc (len);
-
-  sprintf (stub_name, "%08x+%08x",
-	   symbol_section->id & 0xffffffff,
-	   (unsigned int) ((rela->r_addend & 0xffffffff) + symbol_offset));
+  if (stub_name != NULL)
+    sprintf (stub_name, "%08x+%08x",
+	     symbol_section->id & 0xffffffff,
+	     (unsigned int) ((rela->r_addend & 0xffffffff) + symbol_offset));
 
   return stub_name;
 }