Commit: f42f6559f14dc8cf2f0252456165b11f2d9ef6ca - pg_dbms_stats (git)

Commit MetaInfo

• Révision: f42f6559f14dc8cf2f0252456165b11f2d9ef6ca (tree)
• l'heure: 2014-11-14 09:56:14
• Auteur: Kyotaro Horiguchi <horiguchi.kyotaro@lab....>
• Commiter: Kyotaro Horiguchi

Message de Log

Edit ChangeLogs. Fixed some misspellings.

Change Summary

• modified: ChangeLog
• modified: ChangeLog.ja
• modified: README.installcheck
• modified: pg_dbms_stats.c

Modification

--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,19 @@
[phone] Kyotaro Horiguchi <[e-mail]>
+	* pg_dbms_stats.c: Fixed a bug that locked statistics won't be
+	effective when accessing tables without select privilege via
+	views.
+	On the current implement, when planner requested the statistics
+	for a column, pg_dbms_stats takes it from the dummy statistics
+	tables via views which gives stats only of columns that the
+	current user can SELECT.
+	Under that way it works, pg_dbms_stats cannot read the dummy
+	statistics of objects invisible from the current user so accessing
+	such objects via views will done using system statistics, even if
+	their statistics are locked.
+	In order to resolve the problem, privileges for the dummy stats
+	tables and the user under which pg_dbms_stats accesses them are
+	changed.
+
 2014-11-06 Kyotaro Horiguchi <[e-mail]>
 	* pg_dbms_stats.control: Correct default_version.
 
@@ -13,7 +29,7 @@
 	intermediate 0x00 byte and identical lower bytes (for the little
 	endian case). Returning the wrong statistics cache can result in
 	server crash, or at least unexpected plans.
-	* pg_dbms_stats-1.3.3.sql: Lock granurality for pg_dbms_stats's
+	* pg_dbms_stats-1.3.3.sql: Lock granularity for pg_dbms_stats's
 	operations was raised. Simultaneous lock operations on different
 	tables no longer block each other.
 
@@ -38,7 +54,7 @@
 
 	* Added clean_up_stats() function, which erases all saved
 	statistics left alone after deleting tables before unlocking
-	staistics.
+	statistics.
 
 2013-11-07 Kyotaro Horiguchi <[e-mail]>
 	* First published version.

--- a/ChangeLog.ja
+++ b/ChangeLog.ja
@@ -1,3 +1,15 @@
[phone] Kyotaro Horiguchi <[e-mail]>
+	* pg_dbms_stats.c: 権限をもたないテーブルにアクセス可能なビューを通
+	してアクセスした際に、そのテーブルの統計情報をロックしていてもシス
+	テムの統計情報が利用される問題を修正しています。
+
+	現在の実装ではプランナがカラムの統計情報を要求してきた際に
+	pg_dbms_stats は現在のユーザがSELECT権限を持っているカラムについて
+	のみ値を返すビューを通して統計情報を取得しているため、自身がSELECT
+	権限を持たないテーブルにビューを通してアクセスした場合は統計情報ロッ
+	クが働きません。その解決のためダミー統計情報テーブルの権限とそこへ
+	のアクセスの仕方を変更しています。
+
 2014-09-16 Kyotaro Horiguchi <[e-mail]>
 	* pg_dbms_stats.c: 内部の統計情報キャッシュでテーブルの継承状態を正
 	しく扱っていなかったバグを修正しました。この問題により継承テーブル

--- a/README.installcheck
+++ b/README.installcheck
@@ -1,7 +1,7 @@
 Preparation for make installcheck
 
 1. Install pg_dbms_stats into the target binary tree. Make sure to
-   prpare the PATH environment variable properly to execute the right
+   prepare the PATH environment variable properly to execute the right
    pg_config for the version of target PostgreSQL server.
 
   postgres$ which pg_config

--- a/pg_dbms_stats.c
+++ b/pg_dbms_stats.c
@@ -1409,12 +1409,12 @@ init_rel_stats_entry(StatsRelationEntry *entry, Oid relid)
  * the attribute widths for estimation purposes.
  *
  * Note: This function is copied from plancat.c in core source tree of version
- * 9.2, and customized for pg_dbms_stats.  Changes from orignal one are:
+ * 9.2, and customized for pg_dbms_stats.  Changes from original one are:
  *   - rename by prefixing dbms_stats_
  *   - add 3 parameters (relpages, reltuples, curpage) to pass dummy curpage
  *     values.
  *   - Get current # of pages only when supplied curpages is InvalidBlockNumber
- *   - get franction of all-visible-pages
+ *   - get fraction of all-visible-pages
  */
 static void
 dbms_stats_estimate_rel_size(Relation rel, int32 *attr_widths,