Commit: 628fa91f79b76b4f7351a5644f292f91d77eb7ce - pg_hint_plan (git)

firtst release

Commit MetaInfo

• Révision: 628fa91f79b76b4f7351a5644f292f91d77eb7ce (tree)
• l'heure: 2013-11-18 19:08:05
• Auteur: Shigeru HANADA <shigeru.hanada@gmai...>
• Commiter: Shigeru HANADA

Message de Log

Rowsヒントの絶対値指定にもプレフィックスを規定

絶対値の場合は「#10」のようにハッシュを前置する。

Change Summary

• modified: pg_hint_plan.c
• modified: sql/pg_hint_plan.sql

Modification

--- a/pg_hint_plan.c
+++ b/pg_hint_plan.c
@@ -2058,7 +2058,12 @@ RowsHintParse(RowsHint *hint, HintState *hstate, Query *parse,
 
 	/* Retieve rows estimation */
 	rows_str = list_nth(name_list, hint->nrels);
-	if (rows_str[0] == '+')
+	if (rows_str[0] == '#')
+	{
+		hint->value_type = RVT_ABSOLUTE;
+		rows_str++;
+	}
+	else if (rows_str[0] == '+')
 	{
 		hint->value_type = RVT_ADD;
 		rows_str++;
@@ -2080,7 +2085,11 @@ RowsHintParse(RowsHint *hint, HintState *hstate, Query *parse,
 	}
 	else
 	{
-		hint->value_type = RVT_ABSOLUTE;
+		hint_ereport(str,
+					 ("unrecognized rows value type notation.",
+					  hint->base.keyword));
+		hint->base.state = HINT_STATE_ERROR;
+		return str;
 	}
 	hint->rows = strtod(rows_str, &end_ptr);
 	if (*end_ptr)

--- a/sql/pg_hint_plan.sql
+++ b/sql/pg_hint_plan.sql
@@ -845,3 +845,10 @@ BEGIN
 END;
 $$;
 DROP EXTENSION pg_hint_plan;
+
+-- Rows hint tests
+EXPLAIN SELECT * FROM t1 JOIN t2 ON (t1.id = t2.id);
+/*+ Rows(t1 t2 #10) */
+EXPLAIN SELECT * FROM t1 JOIN t2 ON (t1.id = t2.id);
+/*+ Rows(t1 t2 *10) */
+EXPLAIN SELECT * FROM t1 JOIN t2 ON (t1.id = t2.id);