Commit: 5338bc7dd42e09db72354077aab594199a21f584 - MolDS (git)

Commit MetaInfo

• Révision: 5338bc7dd42e09db72354077aab594199a21f584 (tree)
• l'heure: 2011-02-05 14:39:53
• Auteur: Mikiya Fujii <mikiya.fujii@gmai...>
• Commiter: Mikiya Fujii

Message de Log

Cndo2::DoesSCF is refactored to update atomic charge correctlly.

git-svn-id: https://svn.sourceforge.jp/svnroot/molds/MolDS/trunk@83 1136aad2-a195-0410-b898-f5ea1d11b9d8

Change Summary

• modified: src/cndo/Cndo2.h

Modification

--- a/src/cndo/Cndo2.h
+++ b/src/cndo/Cndo2.h
@@ -108,7 +108,6 @@ private:
                  Molecule* molecule);
    void DoesDIIS(double** orbitalElectronPopulation,
                  double** oldOrbitalElectronPopulation,
-                 double* atomicElectronPopulation,
                  double*** diisStoredDensityMatrix,
                  double*** diisStoredErrorVect,
                  double** diisErrorProducts,
@@ -356,16 +355,17 @@ void Cndo2::DoesSCF(){
                                              this->molecule, 
                                              this->fockMatrix);
 
-         // calc. electron population in each atom.
-         this->CalcAtomicElectronPopulation(this->atomicElectronPopulation, 
-                                            this->orbitalElectronPopulation, 
-                                            this->molecule);
 
          // check convergence or update oldpopulation
          if(this->SatisfyConvergenceCriterion(oldOrbitalElectronPopulation, 
                                               this->orbitalElectronPopulation,
                                               this->molecule->GetTotalNumberAOs(), &rmsDensity, i)){
 
+            // calc. electron population in each atom.
+            this->CalcAtomicElectronPopulation(this->atomicElectronPopulation, 
+                                               this->orbitalElectronPopulation, 
+                                               this->molecule);
+
             cout << this->messageSCFMetConvergence;
             this->OutputResults(this->fockMatrix, this->energiesMO, this->atomicElectronPopulation, this->molecule);
             break;
@@ -378,7 +378,6 @@ void Cndo2::DoesSCF(){
             // diis 
             this->DoesDIIS(this->orbitalElectronPopulation,
                            oldOrbitalElectronPopulation,
-                           this->atomicElectronPopulation,
                            diisStoredDensityMatrix,
                            diisStoredErrorVect,
                            diisErrorProducts,
@@ -386,6 +385,11 @@ void Cndo2::DoesSCF(){
                            diisNumErrorVect,
                            this->molecule,
                            i);
+            
+            // calc. electron population in each atom.
+            this->CalcAtomicElectronPopulation(this->atomicElectronPopulation, 
+                                               this->orbitalElectronPopulation, 
+                                               this->molecule);
 
             this->UpdateOldOrbitalElectronPopulation(oldOrbitalElectronPopulation, 
                                                      this->orbitalElectronPopulation, 
@@ -463,7 +467,6 @@ void Cndo2::FreeSCFTemporaryMatrices(double*** oldOrbitalElectronPopulation,
  */
 void Cndo2::DoesDIIS(double** orbitalElectronPopulation,
                      double** oldOrbitalElectronPopulation,
-                     double* atomicElectronPopulation,
                      double*** diisStoredDensityMatrix,
                      double*** diisStoredErrorVect,
                      double** diisErrorProducts,
@@ -538,8 +541,6 @@ void Cndo2::DoesDIIS(double** orbitalElectronPopulation,
             }
          }
 
-         // calc. electron population in each atom.
-         this->CalcAtomicElectronPopulation(atomicElectronPopulation, orbitalElectronPopulation, molecule);
       }
    }
 }