• R/O
  • HTTP
  • SSH
  • HTTPS

Commit

Frequently used words (click to add to your profile)

javac++androidlinuxc#windowsobjective-ccocoa誰得qtpythonphprubygameguibathyscaphec計画中(planning stage)翻訳omegatframeworktwitterdomtestvb.netdirectxゲームエンジンbtronarduinopreviewer

packages/apps/Gallery2


Commit MetaInfo

Révision5b7d5244e942163f0d8debce457de3d9676c7737 (tree)
l'heure2017-11-03 09:47:09
AuteurChih-hung Hsieh <chh@goog...>
Commiterandroid-build-merger

Message de Log

Merge "Use -Werror in packages/apps/Gallery2"
am: 24309021fb

Change-Id: Iee490c18f1d60f20ba19e304614c01fe481ff0d8

Change Summary

Modification

--- a/jni/Android.mk
+++ b/jni/Android.mk
@@ -1,9 +1,16 @@
11 LOCAL_PATH:= $(call my-dir)
22
3+Gallery2_jni_cflags := \
4+ -Wall -Wextra -Werror \
5+ -Wno-error=constant-conversion \
6+ -Wno-unused-parameter \
7+
8+# to fix implicit conversion from 'int' to 'char', (255 to -1, 128 to -128)
9+
310 include $(CLEAR_VARS)
411
5-LOCAL_CFLAGS += -DEGL_EGLEXT_PROTOTYPES -Wno-unused-parameter
6-LOCAL_CFLAGS += -Wall -Wextra
12+LOCAL_CFLAGS += -DEGL_EGLEXT_PROTOTYPES
13+LOCAL_CFLAGS += $(Gallery2_jni_cflags)
714
815 LOCAL_SRC_FILES := jni_egl_fence.cpp
916
@@ -45,8 +52,8 @@ LOCAL_SRC_FILES := filters/gradient.c \
4552 filters/tinyplanet.cc \
4653 filters/kmeans.cc
4754
48-LOCAL_CFLAGS += -ffast-math -O3 -funroll-loops -Wno-unused-parameter
49-LOCAL_CFLAGS += -Wall -Wextra
55+LOCAL_CFLAGS += -ffast-math -O3 -funroll-loops
56+LOCAL_CFLAGS += $(Gallery2_jni_cflags)
5057 LOCAL_LDLIBS := -llog -ljnigraphics
5158 LOCAL_ARM_MODE := arm
5259
--- a/jni_jpegstream/Android.mk
+++ b/jni_jpegstream/Android.mk
@@ -17,7 +17,7 @@ LOCAL_SDK_VERSION := 17
1717 LOCAL_ARM_MODE := arm
1818
1919 LOCAL_CFLAGS += -ffast-math -O3 -funroll-loops
20-LOCAL_CFLAGS += -Wall -Wextra
20+LOCAL_CFLAGS += -Wall -Wextra -Werror
2121 LOCAL_LDLIBS := -llog
2222
2323 LOCAL_CPP_EXTENSION := .cpp