Commit: 1c2c376341d016f7d7da43aa9909043a6738bd5d - hardware-libaudio (git)

hardware/libaudio

Commit MetaInfo

• Révision: 1c2c376341d016f7d7da43aa9909043a6738bd5d (tree)
• l'heure: 2013-09-11 00:42:53
• Auteur: Tueidj <tueidj@hotm...>
• Commiter: Chih-Wei Huang

Message de Log

Fix bad sleep time

The bad sleep time occurs when pcm_get_htimestamp() fails, leaving
kernel_frames uninitialized and causing out->cur_write_threshold to be
set to a very large value. The following patch ensures kernel_frames is
initialized to a sane value, it should fix most of the "limiting sleep
time" warnings and stuttering audio caused by sleeping too much.

Change Summary

• modified: audio_hw.c

Modification

--- a/audio_hw.c
+++ b/audio_hw.c
@@ -715,8 +715,10 @@ static ssize_t out_write(struct audio_stream_out *stream, const void* buffer,
             struct timespec time_stamp;
             if (pcm_get_htimestamp(out->pcm,
                                    (unsigned int *)&kernel_frames,
-                                   &time_stamp) < 0)
+                                   &time_stamp) < 0) {
+                kernel_frames = 0; /* assume no space is available */
                 break;
+            }
             kernel_frames = pcm_get_buffer_size(out->pcm) - kernel_frames;
 
             if (kernel_frames > out->cur_write_threshold) {