packages-apps-Settings

Fork

Merge "Fix the ANR in panel when changing volume continuously" into rvc-qpr-dev

Merge "Fix the endless panel loading" into rvc-qpr-dev

Snap for 6856668 from dacfb93762749197f664d34c10c0c2737b1935bf to rvc-d2-release

Change-Id: I71fe204cc0dd4b96bae0327b6d884f5833d0a1b5

Merge "Add permission to protect data when sending broadcast" into rvc-qpr-dev

Merge "Disable bubbles for low ram devices" into rvc-qpr-dev

Import translations. DO NOT MERGE ANYWHERE

Auto-generated-cl: translation import
Change-Id: I59e6f5297bd364526f80af8b1125a566b869f74a

Merge "Hide the icon if there is no media session or album art." into rvc-qpr-dev

Merge "Update state when there is Bluetooth tethering state changed" into rvc-qpr-dev

Merge "Update global bubble settings mp4" into rvc-qpr-dev

Fix the ANR in panel when changing volume continuously

When users open volume panel and keep on changing the volume slider for
a while, the panel starts to defer the slider updating, and finally gets
stuck and causes an ANR.

Root cause:
Volume panel has four volume adjusting slices. Each of them registers
a broadcast receiver to listen to the volume changed and muted events.
However, when the media volume changes, AudioManager will send four
broadcasts (music, assistant, accessibility, tts) to every receiver, and
each of them will reload slice four times. Thus, one media volume
changed event will lead to 16 (4*4) UI updates. Consequently, keeping on
sliding the volume bar will trigger hundreds of broadcasts and UI
updates, which makes the system busy and getting stuck.

Solution:
Introduce a VolumeSliceHelper to integrate the broadcasts of the volume
slices specifically.
1. Only register one broadcast receiver to reduce the broadcast loading
since the four slices are listening to the same signal.
2. Filter the only one eligible broadcast among the multiple concurrent
ones, and then relay it to the registered slice.
3. Listen to one more action STREAM_DEVICES_CHANGED_ACTION to update the
volume panel when audio output device changes.

Test: robotest, visual
Fixes: 144134209
Fixes: 160489394
Change-Id: I780b9eee35802b19a5f0ab0a7d07bd3e081f5556
Merged-In: I780b9eee35802b19a5f0ab0a7d07bd3e081f5556
(cherry picked from commit 2c7b77dad7f669d3568ea5ae95d6efcb86d53e90)

Fix the endless panel loading

Re-launching volume panel continuously will trigger an endless panel
loading, show a transparent unfinished UI, and then block the user's
screen.

Root cause:
When the activity receives a new intent from user's clicking, it will
call PanelFragment#createPanelContent to update the current fragment.
The method triggers an animation and then loads the panel content. If
multiple invocations run concurrently before the animation or the
loading finish, the loader's countdown latch will be increased
abnormally and lead to the endless loading.

Solution:
1. Since the invocations are in UI thread, simply add a flag to avoid
reentrance when the panel is animating or loading.
2. Filter out the same panel's creation request when the panel is still
visible.
3. Do not force a panel's recreation when it's under construction.

Fixes: 143889510
Fixes: 160491854
Test: robotest, manual
Change-Id: I821faedeb62354929f3af9804cbbe44ee5bb8a53
Merged-In: I821faedeb62354929f3af9804cbbe44ee5bb8a53
(cherry picked from commit 6a8d2c5e553a1c63e28cb877f5b565159e42ed97)

Disable bubbles for low ram devices

Fixes: 167677013
Test: set low ram true => bubble settings hidden
Test: make -j80 RunSettingsRoboTests ROBOTEST_FILTER="Bubble"

Change-Id: I1c40a05404ea7c78cc82102b33e4bc3cb3528075

Merge "Fix the device on "Media devices" not updated issue" into rvc-qpr-dev

Fix the device on "Media devices" not updated issue

- This CL uses new CachedBluetoothDevice callback instance
in construct to avoid unregister wrong callback.
- This CL uses flag to make sure preference will register callback
on onAttached() when preference remove callback on
onPrepareForRemoval() or onDetached().
- Update test case

Bug: 168682778
Bug: 157653997
Test: make -j42 RunSettingsRoboTests
Change-Id: I7a0d9f5332153ee80634e191847b84cd7c380b7d
Merged-In: I7a0d9f5332153ee80634e191847b84cd7c380b7d
(cherry picked from commit cafeab28136320345e12ccfb8e9bf2def10635d8)

Hide the icon if there is no media session or album art.

- Before this CL, the output switch panel will show a default
icon if there is no media session or album art.

This CL will hide the icon if there is no media session
or album art.
- Add test case

Bug: 161495909
Test: make -j42 RunSettingsRoboTests
Change-Id: I5f80158b12f89c8499fb97d0b203ebeffefbc18b
Merged-In: I5f80158b12f89c8499fb97d0b203ebeffefbc18b
(cherry picked from commit 30805af9defa1041ba90add3f00584b92dd9ef0e)

[DO NOT MERGE] Fix the blank space on contextual card loading timeout

Root cause:
Sometimes loading contextual cards exceeds 1 second and a timeout
expires. In the past, we used the timeout in order not to update
homepage UI and to avoid screen scrolling. But we've introduced a
mechanism of card space pre-allocation to avoid flickering, so when the
timeout expires, the pre-allocated space will be always blank.

Solution:
Display a card on timeout if the one-card space is pre-allocated.

Fixes: 165886791
Test: robotest
Change-Id: I79b29c5fd6d9c4fe6b53dd4f5eab4cd3a606d76d

Merge "Fix cast volume control bar not work" into rvc-qpr-dev

Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-qpr-dev

[automerger skipped] Import translations. DO NOT MERGE ANYWHERE am: 1d033b41dc -s ours

am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Settings/+/12642138

Change-Id: I75912992dfd44e72c3e8daf2721be656dbc114b9

Import translations. DO NOT MERGE ANYWHERE

Auto-generated-cl: translation import
Change-Id: I05ee4abf21aa97acf518dbb3f7f1fec36a70445c

Import translations. DO NOT MERGE ANYWHERE

Auto-generated-cl: translation import
Change-Id: I2553421a8fef1330908cba8afc10013ce6331778

Update global bubble settings mp4

Fixes: 160797563
Test: compiles with updated overflow button icon
Change-Id: Iaa1319bfb6f111b7675f5682258a8d282c27c6ce

Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-qpr-dev

Merge "Import translations. DO NOT MERGE ANYWHERE" into rvc-qpr-dev

Merge "[DO NOT MERGE] Revert "Allow user to block individual apps from resuming."" into rvc-qpr-dev

[DO NOT MERGE] Revert "Allow user to block individual apps from resuming."

Revert submission 12392268-cherrypick-mediaappsettings-5fxuo164a2

Bug: 161813143

Reason for revert: no longer want change in QPR
Reverted Changes:
Id3de52419:Allow user to block individual apps from resuming....
I8c85bc937:Allow user to block individual apps from resuming

Change-Id: Ieacef217587476532246b466d680219351bc1657

Import translations. DO NOT MERGE ANYWHERE

Auto-generated-cl: translation import
Change-Id: Ic2d693eb2a6060bd39063cd1e1b6a677c555a500

Import translations. DO NOT MERGE ANYWHERE

Auto-generated-cl: translation import
Change-Id: I808f46f1aaebeccdfd1bf4c0c561925830b97717

Fix cast volume control bar not work

Use hashcode as a requestCode id, since the
same requestCode will cause the intent be cached.

Bug: 163095633
Test: make -j42 RunSettingsRoboTests
Change-Id: I2c120f18e24a66aeff5565e952fa4064149ec540
Merged-In: I2c120f18e24a66aeff5565e952fa4064149ec540
(cherry picked from commit 7f3efd435776ebdf3d8b90181d35fb16e5f86bdc)

Do not display eSIM activation option if the device is eSIm ignored

For the device listed as eSIM ignored device, we should always hide the
eSIM activation button even in the developer mode.
Bug: 168266928
Test: Manually tested

Change-Id: Ide3043606de202c5903e520aa550302ff0d103d3