#44089: cityresult_fill() fetches ai data for no reason
Open Date: 2022-03-13 02:41
Last Update: 2022-04-15 02:21
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44089
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44089
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-04-15 02:21 Updated by: cazfi
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Closed
Priority: 5 - Medium
MileStone: 3.0.2
Component: AI
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
cityresult_fill() fetch both advisor data ('adv') and ai data ('ai'). The only use for the ai data is that its existence is asserted. Event that assert should probably be checking advisor data instead.
All this has likely been introduced when advisor data was first split from ai data, and some functions really needed both while others only one of them. Because the assert it has seemed like the ai data is needed here.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44089
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44089