#44406: Qt: Shortcuts num_shortcuts wrong Open Date: 2022-04-17 15:30 Last Update: 2022-04-17 17:47 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/44406 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44406 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-04-17 17:47 Updated by: cazfi Comment: Fix for #44407 should go in before this - once we save those shortcuts in the end of the array, we don't want to save (so that they may remain in use forever) a wrong one. --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: (None) Type: Bugs Status: Open Priority: 5 - Medium MileStone: (None) Component: Qt-client Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: Qt-client shortcuts.cpp has a "static int num_shortcuts = 57;" which is used at least to tell number of shortcuts to save and load. The value currently isn't same as highest value in 'enum shortcut_id' (nor +1 for considering the value 0) - I'm not yet entirely sure if it should. But I'm sure that it should have been increased when the new shortcut (for toggling Unit Stack Size) was last added, and it was not. So it's certainly wrong, have to just determine how much. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/44406 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44406