#44386: sanity_check_ruleset_data() needs clearing old compat code?
Open Date: 2022-04-15 18:22
Last Update: 2022-04-20 22:26
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44386
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44386
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-04-20 22:26 Updated by: cazfi
Comment:
It doesn't really doable to differentiate between what's supposed to be acceptable conflict in a compat mode, and which are not. The current condition at least makes all conflicts illegal outside compat mode.
What should be changed here, is to do full check also in compat mode, if we are in fact loading ruleset of the current freeciv version's format.
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: S3_1 d3f
Component: Server
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
sanity_check_ruleset_data() comment about ignore_retired is suspicious: "were retired in Freeciv 3.0."
So is the compat code in question supposed to be in later branches? Sounds like it would allow things that were not legal even in the versions that the compatibility is expected with (3.0 compat in S3_1, 3.1 compat in master)
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44386
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44386