#45891: Ruledit: Counters count
Open Date: 2022-10-17 20:15
Last Update: 2022-12-31 23:22
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45891
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45891
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-12-31 23:22 Updated by: lachu
Comment:
Reply To cazfi
- Does not apply to current HEAD (counters.c)
- While we currently have only city counters, there's no point in making things specific for them when generic counters support would be as easy (or easier!):
- Drop the "city_" -prefix from the iterator macro name
- Make it to iterate over all counters (up to game.control.num_counters)
- There's trailing space in the macro. You may want to check your git/terminal settings to make sure 'git diff' shows these to you on easily noticed color.
- What you are including "support.h" for, to counters.h? Don't see rest of the change to the file requiring anything from there. If it does, add "/* utility */" header for the include group
2022-12-31 23:22 Updated by: lachu
File 0001-OSDN-Ticket-45891-S-awomir-Lach-slawek-lach.art.pl.patch (File ID: 11265) is attached
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Patches
Status: Open
Priority: 5 - Medium
MileStone: 3.2.0
Component: Ruledit and ruleup
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
Ruledit should show number of counters in the ruleset in the statistics.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45891
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45891