#44696: Lua: allow edit.create_building() to move a great wonder Open Date: 2022-05-28 13:30 Last Update: 2022-06-03 02:42 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/44696 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44696 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-06-03 02:42 Updated by: ihnatus Comment: I have caused a lot... Well, reworking this. What really should be fixed in process: Lua does not refresh the cities before sending or rearrange the workers if the building changes the radius. Lua may put a coinage into the city that works buggy. Editor (client and server part) considers any Special genus building unplaceable. While the reciprocal is more or less guaranteed by ruleset loading, the straight seems to be not true. Making Special genus building obligatory either a mint or a space part is a format change (let alone the fact that wether something is a space part is calculated dependent to the current state of the city it's being built in). I will replace the check to reflect the current logic of city_build_building() but maybe we should change something, at least in 3.2, and this change should go also to 3.0. What is not to be handled in this patch: Building obsoletion Trade route effects for third party cities (actually, I didn't check, maybe client calculates them?) Both editor and Lua don't call Lua "building_built/lost" callbacks, shouldn't they? --------------------------------------------------------------------- Ticket Status: Reporter: ihnatus Owner: (None) Type: Feature Requests Status: Open Priority: 5 - Medium MileStone: S3_1 d3f Component: Scripting API Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: This effect is already achievable with edit.remove_building() called first, it's not natural to hide the opportunity. Also, editing from client can do it. -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/44696 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44696