[Freeciv-tickets] [freeciv] #44738: Split create_unit_full() in two functions

Back to archive index
OSDN Ticket System norep****@osdn*****
Fri Jun 17 16:56:29 JST 2022


#44738: Split create_unit_full() in two functions

  Open Date: 2022-05-31 23:55
Last Update: 2022-06-17 10:56

URL for this Ticket:
    https://osdn.net//projects/freeciv/ticket/44738
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44738

---------------------------------------------------------------------

Last Changes/Comment on this Ticket:
2022-06-17 10:56 Updated by: cazfi

Comment:

It might be a coincidence that #44847 occurred at the autogame run where this patch was first included, but I'll keep this on hold a bit longer, until we know more about the failure.

---------------------------------------------------------------------
Ticket Status:

      Reporter: ihnatus
         Owner: cazfi
          Type: Feature Requests
        Status: Open [Owner assigned]
      Priority: 5 - Medium
     MileStone: 3.1.0
     Component: Server
      Severity: 5 - Medium
    Resolution: Accepted
---------------------------------------------------------------------

Ticket details:

For consistency, we should have an option to do separately two things that create_unit_full() does together and mixes up:
Create a virtual unit, supply all necessary parameters to it and
Put a preset virtual unit into the game, recording it in all the lists and structures.
The downside of what is now is that in e.g. unit_change_owner() we create a unit, put it into the game and then make some raw adjustments, e.g. set its nationality and movepoints. We call AI callbacks before we do it; if now they don't interest these parameters, afterwards they may.
Actually, I have in mind a pair of patches for later versions that need it, but even for 3.0 it would be better.

-- 
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN

Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net

URL for this Ticket:
    https://osdn.net/projects/freeciv/ticket/44738
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44738



More information about the Freeciv-tickets mailing list
Back to archive index