#44882: citizenshand.c doing useless work when FREECIV_DEBUG not set Open Date: 2022-06-20 17:00 Last Update: 2022-06-22 20:03 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/44882 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44882 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2022-06-22 20:03 Updated by: cazfi * Owner Update from (None) to cazfi * Resolution Update from None to Accepted * Milestone Update from (None) to 3.1.0 Comment: Fix to immediate build issues (as quickly reproduced - can't promise there isn't failing corner cases still) attached. Will push immediately. --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: cazfi Type: Bugs Status: Open [Owner assigned] Priority: 9 - Highest MileStone: 3.1.0 Component: Server Severity: 5 - Medium Resolution: Accepted --------------------------------------------------------------------- Ticket details: ../../../src/server/citizenshand.c:159:18: warning: variable 'pplayer' set but not used [-Wunused-but-set-variable!] That's basically because pplayer would only be used in log_citizens(), which currently is defined as log_debug(), which expands to nothing when FREECIV_DEBUG is not set. Ideally the fix would support changing log_citizens() to be something else than log_debug() -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/44882 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44882