#44082: req_text_insert(): Fallthrough from VUT_CITYSTATUS to VUT_MINLATITUDE
Open Date: 2022-03-12 15:53
Last Update: 2022-03-23 19:30
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/44082
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44082
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-03-23 19:30 Updated by: cazfi
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Closed
Priority: 5 - Medium
MileStone: 3.1.0
Component: General
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
Compiling master with --enable-debug=checks:
../../../src/common/reqtext.c: In function ‘req_text_insert’:
../../../src/common/reqtext.c:2888:12: error: this statement may fall through (-Werror=implicit-fallthrough=)
2888 | } else {
|
../../../src/common/reqtext.c:2949:3: note: here
2949 | case VUT_MINLATITUDE:
Seems like a genuine bug; unsupported ranges just "break;" from the inner switch, and there's neither break or return after that to prevent falling through in the outer switch.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/44082
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=44082