#42992: Inconsistent code about "Local" range "Good" reqs
Open Date: 2021-10-07 11:30
Last Update: 2022-10-07 03:18
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/42992
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42992
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-10-07 03:18 Updated by: cazfi
* Milestone Update from 3.0.4 to 3.0.5
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: (None)
Type: Bugs
Status: Open
Priority: 5 - Medium
MileStone: 3.0.5
Component: General
Severity: 5 - Medium
Resolution: None
---------------------------------------------------------------------
Ticket details:
When looking #42944
Additional inconsistency is that is_goods_type_in_range() would accept "Local" range, if the ruleset loading would ever let it through. As currently implemented, it's identical to "City" range, but I guess the idea might have been that it should check if the local tile has a city with the good imported, i.e., there would be slight semantic difference between "Local" and "City" causing evaluation to be against different city in some cases.
As the ruleset loading time checks guard against ever getting Good requirement with "Local" range, resolving this issue is not urgent, end especially a solution where the functionality gets extended can only occur in later branches that are not yet d3f.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/42992
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=42992