#45487: auto_arrange_workers(): Unnecessary cm_parameter copy
Open Date: 2022-08-28 00:43
Last Update: 2022-10-15 04:52
URL for this Ticket:
https://osdn.net//projects/freeciv/ticket/45487
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45487
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2022-10-15 04:52 Updated by: cazfi
* Status Update from Open to Closed
* Resolution Update from Accepted to Fixed
---------------------------------------------------------------------
Ticket Status:
Reporter: cazfi
Owner: cazfi
Type: Bugs
Status: Closed
Priority: 5 - Medium
MileStone: 3.1.0
Component: Server
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
auto_arrange_workers() always uses local cm_parameter structure. Therefore it has to copy the parameter from pcity->cm_parameter to that local structure. AFAIK there's no reason not to use pcity->cm_parameter directly in the usual case, only creating a copy if we have to do local modifications.
--
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN
Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net/projects/freeciv/ticket/45487
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45487