#45067: cities_iterate() as hash_data_iterate() Open Date: 2022-07-08 12:14 Last Update: 2023-06-12 03:21 URL for this Ticket: https://osdn.net//projects/freeciv/ticket/45067 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45067 --------------------------------------------------------------------- Last Changes/Comment on this Ticket: 2023-06-12 03:21 Updated by: cazfi Comment: Not sure if this would retain game reproducibility, i.e., does hash_data_iterate() go through entries in the same order, e.g., after save/server restart/load. --------------------------------------------------------------------- Ticket Status: Reporter: cazfi Owner: (None) Type: Patches Status: Open Priority: 5 - Medium MileStone: (None) Component: General Severity: 5 - Medium Resolution: None --------------------------------------------------------------------- Ticket details: Currently cities_iterate() is implemented as iteration of player's city list inside iteration of players. It's likely that hash_data_iterate() from the cities hash would have better performance. Should at least measure it (and then document the result, so we know in the future that it has been already done) -- Ticket information of Freeciv project Freeciv Project is hosted on OSDN Project URL: https://osdn.net/projects/freeciv/ OSDN: https://osdn.net URL for this Ticket: https://osdn.net/projects/freeciv/ticket/45067 RSS feed for this Ticket: https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=45067