[Freeciv-tickets] [freeciv] #47967: gitrev is wrong in freeciv-server -v

Back to archive index
OSDN Ticket System norep****@osdn*****
Tue May 2 01:31:59 JST 2023


#47967: gitrev is wrong  in  freeciv-server -v

  Open Date: 2023-04-30 00:58
Last Update: 2023-05-01 19:31

URL for this Ticket:
    https://osdn.net//projects/freeciv/ticket/47967
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47967

---------------------------------------------------------------------

Last Changes/Comment on this Ticket:
2023-05-01 19:31 Updated by: cazfi

Comment:

Reply To alain_bkr
1/ i don't know how to translate the word "modified" inside the string, and i would advocate it is not that important, because it occurs only when one has some uncommitted changes, so i guess that person would understand :-)
Existing code translates REV1:
  fc_snprintf(buf, sizeof(buf), "%s%s",
              translate ? _(FC_GITREV1) : FC_GITREV1, FC_GITREV2);
The string is collected from translations/Strings.txt
Not that it would be important, but it shouldn't be that hard either.

---------------------------------------------------------------------
Ticket Status:

      Reporter: alain_bkr
         Owner: (None)
          Type: Bugs
        Status: Open
      Priority: 7
     MileStone: (None)
     Component: General
      Severity: 5 - Medium
    Resolution: None
---------------------------------------------------------------------

Ticket details:

S3_1
The value return buy freeciv-server -v is an old reference (in example 164 commit behind origin/S3_1 pulled today)
$ LANG=en ./server/freeciv-server -v
Encodings: Data=UTF-8, Local=ISO-8859-1, Internal=UTF-8
Freeciv version 3.1.0-beta1+ (beta version) (modified 75200a454) 

$ git log origin/S3_1...75200a454 | grep commit | wc -l
164
It seems that the values of  bootstrap/generate_gitrev.sh -> ./common/fc_gitrev_gen.h are not taken into account and we have a fallback from somewhere.


-- 
Ticket information of Freeciv project
Freeciv Project is hosted on OSDN

Project URL: https://osdn.net/projects/freeciv/
OSDN: https://osdn.net

URL for this Ticket:
    https://osdn.net/projects/freeciv/ticket/47967
RSS feed for this Ticket:
    https://osdn.net/ticket/ticket_rss.php?group_id=12505&tid=47967



More information about the Freeciv-tickets mailing list
Back to archive index