Ticket #41796

NoVeteran in effects but not in use

Date d'ouverture: 2021-03-17 03:21 Dernière mise à jour: 2023-09-02 17:35

Rapporteur:
Propriétaire:
Type:
État:
Atteints
Composant:
Priorité:
5 - moyen
Sévérité:
5 - moyen
Résolution:
Fixed
Fichier:
3

Détails

The rulesets civ2civ3, classic, experimental, sanndbox and webperimental mention the NoVeteran flag in effects but no unit has the flag.

Ticket History (3/12 Histories)

2021-03-17 03:21 Updated by: kvilhaugsvik
  • New Ticket "NoVeteran in effects but not in use" created
2021-03-20 04:28 Updated by: ihnatus
Commentaire

Might be, it's a good preparation for the case they ever appear, and we should just omit such requirements when we load the ruleset?

2021-03-20 05:53 Updated by: kvilhaugsvik
Commentaire

Reply To ihnatus

we should just omit such requirements when we load the ruleset?

No point omitting them. A !present requirement for a flag not in use is always fulfilled.

2021-03-20 06:14 Updated by: cazfi
Commentaire

Also, we should not omit any rules from the ruleset at loading time - that would leave them out also when saving rules back from ruledit or ruleup. We even have to store some meta-rules that have any effect only at ruleset loading time.

2021-03-20 19:42 Updated by: ihnatus
Commentaire

Reply To kvilhaugsvik

Reply To ihnatus

we should just omit such requirements when we load the ruleset?

No point omitting them. A !present requirement for a flag not in use is always fulfilled.

Just for a bit of productivity. But per Cazfi, maybe not worth the work.

2023-05-12 13:18 Updated by: cazfi
Commentaire

Reply To kvilhaugsvik

The rulesets civ2civ3, classic, experimental, sanndbox and webperimental mention the NoVeteran flag in effects but no unit has the flag.

See also #48028 (affects main -> 3.3+)

2023-06-26 20:56 Updated by: cazfi
  • Jalon Update from (Aucun) to 3.0.9 (atteints)
  • Composant Update from (Aucun) to Rulesets
2023-08-27 13:03 Updated by: cazfi
  • Propriétaire Update from (Aucun) to cazfi
  • Résolution Update from Aucun to Accepted
Commentaire

Reply To cazfi

See also #48028 (affects main -> 3.3+)

Thus main is not affected. Patches for S3_0 - S3_2 attached.

2023-09-02 17:35 Updated by: cazfi
  • État Update from Ouvert to Atteints
  • Résolution Update from Accepted to Fixed

Modifier

Please login to add comment to this ticket » Connexion