adv_unit_execute_path() moves left assert fail

• Rapporteur: cazfi
• Propriétaire: (Aucun)
• Type: Bogues
• État: Ouvert
• Composant: (Aucun)
• Jalon: (Aucun)
• Priorité: 5 - moyen
• Sévérité: 5 - moyen
• Résolution: Aucun
• Fichier: 1

Détails

S3_0 civ2 ruleset autogame:

0: - 2021/04/07 21:43:59 in adv_unit_execute_path() [../../../src/server/advisors/advgoto.c::94]: assertion 'punit->moves_left < unit_move_rate(punit) || punit->fuel < utype_fuel(unit_type_get(punit))' failed.

0: - 2021/04/07 21:43:59 in adv_unit_execute_path() [../../../src/server/advisors/advgoto.c::94]: Settlers waits at 61,57 for no visible profit

0: - 2021/04/07 21:43:59 in adv_unit_execute_path() [../../../src/server/advisors/advgoto.c::94]: Please report this message at https://osdn.net/projects/freeciv/ticket/

I'll try to reproduce.

Ticket History (3/7 Histories)

2021-04-08 04:20 Updated by: cazfi

• New Ticket "adv_unit_execute_path() moves left assert fail" created

2021-04-08 04:43 Updated by: cazfi

• File civ2fuelassert.serv (File ID: 6440) is attached

2021-04-08 04:43 Updated by: cazfi

Commentaire

commit id: 2e47d387aec5bc83098054d95809b3f77a28ce47

Applied patches https://www.hostedredmine.com/issues/899919 and #41781

Attached autogame asserts.

(gdb) p game.info.turn

$1 = 91

2021-04-08 12:25 Updated by: cazfi

Commentaire

Backtrace shows the settler to be in the middle of amphibious move. Maybe it's waiting for the ferry?

2021-04-09 19:38 Updated by: cazfi

Commentaire

There has been similar failure with S3_0 civ1 autogame.

2021-04-11 16:46 Updated by: cazfi

Commentaire

In S3_1, quite a high percentage of autogames ended to this assert failure; civ1, civ2, civ2civ3, sandbox, variant2. I've not seen any game in S2_6 to fail because of this.

2021-04-19 22:09 Updated by: cazfi

Commentaire

Keeping this ticket for fixing the error the assert is finding, but opened a new ticket about disabling the assert by default -> #42029. That would be enough to avoid the regression, and would allow us to make next releases even before the the bug gets fixed.