Ticket #42127

S3_0 ruleup has no --clean option to allow updating without causing deprecation warnings

Date d'ouverture: 2021-05-01 18:24 Dernière mise à jour: 2022-10-05 10:24

Rapporteur:
Propriétaire:
Type:
État:
Atteints
Composant:
Priorité:
5 - moyen
Sévérité:
5 - moyen
Résolution:
Rejected
Fichier:
1

Détails

Loading classic ruleset ruleup'd from S2_6 to S3_0 result in deprecation warning:

Action enabler for "Capture Units" is never used by any unit.

Same for "Bombard" and "Conquer City" actions.

Ticket History (3/13 Histories)

2021-05-01 18:24 Updated by: cazfi
  • New Ticket "classic ruleset after ruleup 2.6 -> 3.0: Action enabler for "Capture Units" is never used by any unit." created
2021-05-01 18:25 Updated by: cazfi
  • Details Updated
2021-05-02 18:53 Updated by: cazfi
2021-05-04 11:44 Updated by: cazfi
Commentaire

Similar ("...us never used by any unit.") messages received from other ruleset as well, also in S3_1 after 3.0 -> 3.1 ruleup. I've attached a log file from a S3_1 run with ruleup'd rulesets.

2021-05-04 20:17 Updated by: kvilhaugsvik
Commentaire

Reply To cazfi

Similar ("...us never used by any unit.") messages received from other ruleset as well, also in S3_1 after 3.0 -> 3.1 ruleup. I've attached a log file from a S3_1 run with ruleup'd rulesets.

No --clean when updating?

2021-05-04 21:29 Updated by: cazfi
Commentaire

Reply To kvilhaugsvik

Reply To cazfi

Similar ("...us never used by any unit.") messages received from other ruleset as well, also in S3_1 after 3.0 -> 3.1 ruleup. I've attached a log file from a S3_1 run with ruleup'd rulesets.

No --clean when updating?

No. And I know I were against having it as the default. What I would consider the most correct (default) behavior would be to not remove any rules written by a human (no --clean), but not to cause unused rules when converting old hardcoded behaviors to a more generic ruleset format (--clean). That's probably too complex to implement? So current behavior is acceptable compromise. Except for the small detail that there is no --clean option in S3_0 to fix those warnings when wanted.

2021-09-26 11:29 Updated by: cazfi
Commentaire

Reply To cazfi

Except for the small detail that there is no --clean option in S3_0 to fix those warnings when wanted.

That's what this ticket is about now.

2022-02-03 13:04 Updated by: cazfi
Commentaire

Is this something that is possible to implement in S3_0 (in practice), or does it depend on other changes not in that branch?

2022-04-13 20:18 Updated by: cazfi
2022-06-11 21:49 Updated by: cazfi
2022-08-05 08:55 Updated by: cazfi
2022-10-05 10:24 Updated by: cazfi
  • État Update from Ouvert to Atteints
  • Propriétaire Update from (Aucun) to cazfi
  • Résolution Update from Aucun to Rejected
Commentaire

Maybe it's time to drop this ticket - it's sort of late to start making that change to mature release branch.

Attachment File List

Modifier

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » Connexion