dai_calc_data() income calculation does not include immediately spent part

• Rapporteur: cazfi
• Propriétaire: cazfi
• Type: Bogues
• État: Atteints
• Composant: AI
• Jalon: 2.6.6 (atteints)
• Priorité: 5 - moyen
• Sévérité: 5 - moyen
• Résolution: Fixed
• Fichier: 1

Détails

dai_calc_data() counts only 'surplus' as income, not including what's being immediately spent. Expenses are correctly calculated. So in perfect balance 'income' is returned as zero, and expenses as some high number. Callers then think that expenses > income.

Ticket History (3/9 Histories)

2021-05-07 18:47 Updated by: cazfi

• New Ticket "dai_calc_data() income calculation does not include immediately spent part" created

2021-05-07 22:40 Updated by: cazfi

• File 0053-AI-Consider-immediately-spent-gold-as-part-of-income.patch (File ID: 6728) is attached

2021-05-07 22:40 Updated by: cazfi

• Résolution Update from Aucun to Accepted
• Jalon Update from (Aucun) to 2.6.5 (atteints)

2021-05-07 22:46 Updated by: chippo

Commentaire

It applies cleanly to S3_0. Can I expect it to do anything on it's own?

2021-05-07 22:58 Updated by: cazfi

Commentaire

Reply To chippo

It applies cleanly to S3_0. Can I expect it to do anything on it's own?

There should be a slight improvement to overall AI performance, but you would need to apply statistical methods to see them - variations between individual games are bigger than effects of the bug fixed. With civ2civ3 #42191 might override any improved calculation correctness, so you would need to use e.g. classic ruleset.

2021-05-23 16:16 Updated by: cazfi

Commentaire

Reply To cazfi

Reply To chippo

It applies cleanly to S3_0. Can I expect it to do anything on it's own?

There should be a slight improvement to overall AI performance, but you would need to apply statistical methods to see them - variations between individual games are bigger than effects of the bug fixed. With civ2civ3 #42191 might override any improved calculation correctness, so you would need to use e.g. classic ruleset.

Actually, it might show up as AI having lower tax rate. It uses income calculated by dai_calc_data() when deciding how high tax rate it needs for a balanced budget.

2021-06-02 23:11 Updated by: cazfi

• Jalon Update from 2.6.5 (atteints) to 2.6.6 (atteints)

2021-07-09 14:45 Updated by: cazfi

• État Update from Ouvert to Atteints
• Propriétaire Update from (Aucun) to cazfi
• Résolution Update from Accepted to Fixed

Commentaire

(This comment has been deleted)

2024-10-09 14:18 Updated by: cazfi

• Summary Updated