Ticket #42994

Sanity check Wonder upkeep

Date d'ouverture: 2021-10-08 01:33 Dernière mise à jour: 2021-10-19 13:39

Rapporteur:
Propriétaire:
Type:
État:
Atteints
Composant:
Priorité:
5 - moyen
Sévérité:
5 - moyen
Résolution:
Fixed
Fichier:
4

Détails

Related to #42993 reported by Lexxie. There should be ruleset loading time sanity check that upkeep value given for a wonder is zero. Wonder upkeep is already always considered zero, but the ruleset author is being left under impression that the nonzero value from the ruleset is being accepted.

Ticket History (3/10 Histories)

2021-10-08 01:33 Updated by: cazfi
  • New Ticket "Sanity check Wonder upkeep" created
2021-10-09 14:32 Updated by: cazfi
  • Résolution Update from Aucun to Accepted
  • Jalon Update from (Aucun) to 2.6.6 (atteints)
2021-10-09 15:51 Updated by: cazfi
Commentaire

Alien ruleset fails this sanity check: #43002

That needs to be addressed before applying this. Moreover, we probably should not completely fail loading rulesets that previously loaded fine in d3f branches.

2021-10-10 03:29 Updated by: cazfi
Commentaire

Reply To cazfi

Moreover, we probably should not completely fail loading rulesets that previously loaded fine in d3f branches.

Attached new versions of the patch for S2_6 and S3_0 that give just deprecation warning when there's wonder with nonzero upkeep.

2021-10-12 17:23 Updated by: cazfi
Commentaire

Before this can be pushed, master needs #43033 and S3_1 #43006

2021-10-19 13:39 Updated by: cazfi
  • État Update from Ouvert to Atteints
  • Propriétaire Update from (Aucun) to cazfi
  • Résolution Update from Accepted to Fixed

Modifier

Please login to add comment to this ticket » Connexion