Rename ACTION_STARTED_... as ACTION_PERFORM_...

• Rapporteur: cazfi
• Propriétaire: cazfi
• Type: Patches
• État: Atteints
• Composant: Server
• Jalon: 3.1.0 (atteints)
• Priorité: 5 - moyen
• Sévérité: 5 - moyen
• Résolution: Fixed
• Fichier: 2

Détails Répondre

ACTION_STARTED_... macros actually are *not* only about starting the action, but about performing it in full (all the way of paying movement costs etc *after* the action). Rename them accordingly as ACTION_PERFORM_...

This came up as I looked up where to add emitting signal for *ending* the action (https://www.hostedredmine.com/issues/817749). Turns out it's place is would be within the _STARTED_ macro.

Ticket History (3/5 Histories)

2021-11-13 21:53 Updated by: cazfi

• New Ticket "Rename ACTION_STARTED_... as ACTION_PERFORM_..." created

2021-11-13 21:59 Updated by: cazfi

• File 0030-Rename-ACTION_STARTED_.-macros-as-ACTION_PERFORM_.patch (File ID: 7938) is attached

2021-11-13 21:59 Updated by: cazfi

• File 0022-Rename-ACTION_STARTED_.-macros-as-ACTION_PERFORM_.patch (File ID: 7939) is attached

2021-11-13 21:59 Updated by: cazfi

• Résolution Update from Aucun to Accepted
• Jalon Update from (Aucun) to 3.1.0 (atteints)

2021-11-28 19:25 Updated by: cazfi

• État Update from Ouvert to Atteints
• Propriétaire Update from (Aucun) to cazfi
• Résolution Update from Accepted to Fixed