Ticket #43979

generate_packets.py: generate_stats doesn't work

Date d'ouverture: 2022-02-25 09:15 Dernière mise à jour: 2022-03-01 19:58

Rapporteur:
Propriétaire:
Type:
État:
Atteints
Composant:
Jalon:
Priorité:
5 - moyen
Sévérité:
5 - moyen
Résolution:
Fixed
Fichier:
1

Détails

The generate_stats option, which, prior to #43938, can only be set by changing the code, and which has never been enabled, doesn't work (crashes with an AttributeError). It can't ever have worked, even in the original version of the script.

Since the option has apparently never been used in its over eighteen years of existing, the question is whether it's worth fixing, or should be removed entirely.

Ticket History (3/4 Histories)

2022-02-25 09:15 Updated by: alienvalkyrie
  • New Ticket "generate_packets.py: generate_stats doesn't work" created
2022-02-26 23:58 Updated by: alienvalkyrie
  • Propriétaire Update from (Aucun) to alienvalkyrie
  • Résolution Update from Aucun to Accepted
Commentaire

The attached fix is relatively simple and generates compiling code that works as usual without issues. However, because of #43988, the resulting stats generation cannot easily be tested in its natural environment yet.

Update: I tested it with a temporary, ad-hoc fix for #43988, and everything seems to be in order.

(Edited, 2022-02-27 02:26 Updated by: alienvalkyrie)
2022-03-01 19:58 Updated by: alienvalkyrie
  • État Update from Ouvert to Atteints
  • Résolution Update from Accepted to Fixed

Modifier

Please login to add comment to this ticket » Connexion