S3_0 legacysave.c nplayers check only when asserts enabled

• Rapporteur: cazfi
• Propriétaire: cazfi
• Type: Bogues
• État: Atteints
• Composant: Server
• Jalon: 3.0.1 (atteints)
• Priorité: 5 - moyen
• Sévérité: 5 - moyen
• Résolution: Fixed
• Fichier: 2

Détails

S3_0 legacysave.c checks consistency on player count from the savegame in an assert(). That's wrong as savegame is external data, that can be wrong even if the freeciv program is correct. The consistency should be checked also when asserts (for programs internal logic) are not enabled.

Ticket History (3/5 Histories)

2022-03-17 10:23 Updated by: cazfi

• New Ticket "S3_0 legacysave.c nplayers check only when asserts enabled" created

2022-03-17 10:29 Updated by: cazfi

• File 0021-Legacy-save-Handle-player-count-inconsistency-also-i.patch (File ID: 8776) is attached

2022-03-17 10:29 Updated by: cazfi

• File 0006-Legacy-save-Handle-player-count-inconsistency-also-i.patch (File ID: 8777) is attached

2022-03-17 10:29 Updated by: cazfi

• Propriétaire Update from (Aucun) to cazfi
• Résolution Update from Aucun to Accepted

Commentaire

Also S2_6 version attached, without introducing new translatable string.

2022-03-18 23:42 Updated by: cazfi

• État Update from Ouvert to Atteints
• Résolution Update from Accepted to Fixed