Ticket #45240

Garbage defender in send_combat()

Date d'ouverture: 2022-07-26 19:27 Dernière mise à jour: 2022-08-10 15:26

Rapporteur:
Propriétaire:
Type:
État:
Atteints
Composant:
Jalon:
Priorité:
5 - moyen
Sévérité:
5 - moyen
Résolution:
Fixed
Fichier:
1

Détails

I'm looking at map_get_seen() segfault with the new fantasy ruleset. So far it seems that pdefender in send_combat() is garbage pointer (or at least it points to garbage content), which then leads to garbage playermap pointer to access seen counters.

Ticket History (3/6 Histories)

2022-07-26 19:27 Updated by: cazfi
  • New Ticket "Garbage defender in send_combat()" created
2022-07-26 19:52 Updated by: cazfi
Commentaire

It seems that unit_attack_civilian_casualties() call causes the city to get destroyed, taking supported units with it, and the failed defender was one of those.

2022-07-26 19:55 Updated by: cazfi
  • Jalon Update from (Aucun) to 3.2.0
  • Composant Update from (Aucun) to Server
Commentaire

Only master affected, as older branches do not reduce city size in case it's already 1, i.e., city never gets destroyed in that call.

2022-08-01 12:36 Updated by: cazfi
  • Propriétaire Update from (Aucun) to cazfi
  • Résolution Update from Aucun to Accepted
2022-08-10 15:26 Updated by: cazfi
  • État Update from Ouvert to Atteints
  • Résolution Update from Accepted to Fixed

Modifier

Please login to add comment to this ticket » Connexion