Ticket #45428

Sanity check rule_name uniqueness

Date d'ouverture: 2022-08-23 05:02 Dernière mise à jour: 2024-02-09 15:42

Rapporteur:
Propriétaire:
(Aucun)
Type:
État:
Ouvert
Composant:
Jalon:
Priorité:
5 - moyen
Sévérité:
5 - moyen
Résolution:
Aucun
Fichier:
1

Détails

There's no check against multiple ruleset items (of the same type) having the same rule_name.

Ticket History (3/5 Histories)

2022-08-23 05:02 Updated by: cazfi
  • New Ticket "Sanity check rule_name uniqueness" created
2023-02-28 02:08 Updated by: lachu
Commentaire

Reply To cazfi

There's no check against multiple ruleset items (of the same type) having the same rule_name.

0001-OSDN-TICKET-45428-S-awomir-Lach-slawek-lach.art.pl.patch(19KB)
Done. Using SPECHASH.

I did not analyze Freeciv code, but in general programming dictionaries/hashtables are generating numbers for each kind of key, even it is a string. I remember that. So I use spechash with CString as key and CString as value. We store game name as key and ruledit section name as value. When key exist, we print current name (key) with previous section name (value), with the same game name.

EDIT: Remove typo in this comment.

(Edited, 2023-03-06 01:57 Updated by: lachu)
2023-09-06 21:55 Updated by: cazfi
2024-02-09 15:42 Updated by: cazfi

Attachment File List

Modifier

Please login to add comment to this ticket » Connexion