unit_list_iterate_safe() evaluates 'unitlist' twice

• Rapporteur: cazfi
• Propriétaire: cazfi
• Type: Bogues
• État: Atteints
• Composant: General
• Jalon: 3.0.4 (atteints)
• Priorité: 5 - moyen
• Sévérité: 5 - moyen
• Résolution: Fixed
• Fichier: 1

Détails

unit_list_iterate_safe() evaluates 'unitlist' parameter twice (sometimes); once to get its size, and if the size is above zero, second time to iterate it.

Ticket History (3/4 Histories)

2022-08-27 19:08 Updated by: cazfi

• New Ticket "unit_list_iterate_safe() evaluates 'unitlist' twice" created

2022-09-03 13:36 Updated by: cazfi

• File 0053-_iterate_safe-Evaluate-list-parameter-just-once.patch (File ID: 10233) is attached

2022-09-03 13:38 Updated by: cazfi

• Propriétaire Update from (Aucun) to cazfi
• Résolution Update from Aucun to Accepted
• Jalon Update from (Aucun) to 3.0.4 (atteints)

Commentaire

Equivalent behavior with other _iterate_safe() macros. All fixed in the attached patch. Unlikely to make much difference with current users (but I've not evaluated all of those)

2022-09-13 14:13 Updated by: cazfi

• État Update from Ouvert to Atteints
• Résolution Update from Accepted to Fixed