Ticket #45601

freeciv-gtk3 misbehaves with a dark GTK theme

Date d'ouverture: 2022-09-07 20:13 Dernière mise à jour: 2023-10-02 13:43

Rapporteur:
Propriétaire:
Type:
État:
Atteints
Composant:
Priorité:
5 - moyen
Sévérité:
5 - moyen
Résolution:
Fixed
Fichier:
5

Ticket History (3/22 Histories)

2022-09-07 20:13 Updated by: l29ah
  • New Ticket "freeciv-gtk3 misbehaves with a dark GTK theme" created
2022-09-07 23:39 Updated by: cazfi
Commentaire

What freeciv version is that?

That the yellowish background of the "Freeciv" theme is there despite you using other theme seems a lot like a "old theme leaking to the new one after the switch" -bug fixed long time ago.

2022-09-07 23:54 Updated by: l29ah
Commentaire

Reply To cazfi

What freeciv version is that?

3.0.1

That the yellowish background of the "Freeciv" theme is there despite you using other theme seems a lot like a "old theme leaking to the new one after the switch" -bug fixed long time ago.

I don't use any freeciv theme, launched it first time in my life. The dark theme is the system-wide gtk one. The qt client doesn't try to impose its own background for widgets so it looks much better.

2022-09-08 00:07 Updated by: cazfi
Commentaire

Reply To l29ah

I don't use any freeciv theme, launched it first time in my life. The dark theme is the system-wide gtk one.

Ok, that likely explains it. Thanks for the additional info.

The "Freeciv" theme is freeciv's default one. If you have not changed your freeciv configuration, that's what you get. So likely it's system-wide + freeciv-wide themes conflicting here.

As a workaround, you can try to change also freeciv's theme (client settings -> Graphics -> Theme)

2022-09-10 15:08 Updated by: cazfi
  • Jalon Update from (Aucun) to 3.0.5 (atteints)
  • Composant Update from (Aucun) to Gtk3.22-client
Commentaire

Patches welcome already before 3.0.4, but likely there's nobody looking this before 3.0.5 cycle.

2022-12-03 16:27 Updated by: cazfi
Commentaire

Oh, from the look of the very wide detach buttons ( https://www.hostedredmine.com/issues/853912 ) you really meant it when you said "gtk3-client", i.e., this is not gtk3.22-client (the default). The problematic behavior might be the same, but you may want to switch to better supported client anyway.

2022-12-10 18:30 Updated by: cazfi
2023-02-03 00:35 Updated by: cazfi
2023-04-07 13:02 Updated by: cazfi
2023-06-30 21:08 Updated by: cazfi
2023-09-07 09:44 Updated by: cazfi
Commentaire

Reply To cazfi

"Freeciv" theme is there despite you using other theme seems a lot like a "old theme leaking to the new one after the switch" -bug fixed long time ago.

The system theme and freeciv's active theme seem to have separate providers, that can exist simultaneously. Likely that's the cause of this bug, mixing those two themes.

2023-09-10 19:50 Updated by: cazfi
Commentaire

Another bug that might be related, even duplicate (same root reason), or maybe not: #48580

2023-09-20 01:48 Updated by: cazfi
Commentaire

Reply To cazfi

Reply To cazfi

"Freeciv" theme is there despite you using other theme seems a lot like a "old theme leaking to the new one after the switch" -bug fixed long time ago.

The system theme and freeciv's active theme seem to have separate providers, that can exist simultaneously. Likely that's the cause of this bug, mixing those two themes.

Equivalent ticket for gtk4-client: #48679

2023-09-27 01:40 Updated by: cazfi
  • Propriétaire Update from (Aucun) to cazfi
  • Résolution Update from Aucun to Accepted
Commentaire

Patches for all branches, including S2_6, attached.

2023-10-01 07:52 Updated by: cazfi
Commentaire

Will need adjustments because of #48770 - I assume dropping gtk3-client part (to handle only gtk3.22-client)

2023-10-01 12:34 Updated by: cazfi
Commentaire

Reply To cazfi

Will need adjustments because of #48770 - I assume dropping gtk3-client part (to handle only gtk3.22-client)

Attached new versions of the patch for S2_6 - S3_1 (branches with gtk3-client)

2023-10-02 13:43 Updated by: cazfi
  • État Update from Ouvert to Atteints
  • Résolution Update from Accepted to Fixed

Modifier

Please login to add comment to this ticket » Connexion