sdl2: create_vertical_surface() 'High' rename

• Rapporteur: cazfi
• Propriétaire: cazfi
• Type: Patches
• État: Atteints
• Composant: SDL2-client
• Jalon: 3.0.4 (atteints)
• Priorité: 5 - moyen
• Sévérité: 5 - moyen
• Résolution: Fixed
• Fichier: 2

Détails

create_vertical_surface() header: "height depend of 'High' parameter." - maybe the parameter should be called 'height' then (it's not a boolean, but an int)

Ticket History (3/6 Histories)

2022-09-20 18:11 Updated by: cazfi

• New Ticket "sdl2: create_vertical_surface() 'High' rename" created

2022-09-30 08:16 Updated by: cazfi

Commentaire

create_horizontal_surface() header has it worse, presumably as partial copy+paste: "height depend on 'width'"

2022-09-30 08:32 Updated by: cazfi

• File 0025-sdl2-Rename-create_vertical_surface-High-as-height.patch (File ID: 10422) is attached

2022-09-30 08:32 Updated by: cazfi

• File 0032-sdl2-Rename-create_vertical_surface-High-as-height.patch (File ID: 10423) is attached

2022-09-30 08:33 Updated by: cazfi

• Propriétaire Update from (Aucun) to cazfi
• Résolution Update from Aucun to Accepted
• Jalon Update from (Aucun) to 3.0.4 (atteints)

Commentaire

Reply To cazfi

create_horizontal_surface() header has it worse, presumably as partial copy+paste: "height depend on 'width'"

And for that actual error in a function header, I want to backport this fix to S3_0 too.

2022-10-03 11:51 Updated by: cazfi

• État Update from Ouvert to Atteints
• Résolution Update from Accepted to Fixed