Ticket #45716

generate_packets.py: Replace unfill with bit-copy/move

Date d'ouverture: 2022-09-25 22:57 Dernière mise à jour: 2022-09-28 22:25

Rapporteur:
Propriétaire:
Type:
État:
Atteints
Composant:
Jalon:
Priorité:
5 - moyen
Sévérité:
5 - moyen
Résolution:
Fixed
Fichier:
1

Détails

Part of #43927. The unfill concept introduced in #45222 as a mirror to fill is ultimately misguided; the actual use case is backing up the received key fields while zeroing a packet struct (to initialize the cache), which amounts to temporarily moving those values out of the struct – this is better achieved by bitcopying the data, i.e. a straight assignment (for non-arrays at least). In contrast, fill clones the data, which is not what we want here (and which could cause problems if and when we start to support types that need to be destroyed explicitly).

Ticket History (3/4 Histories)

2022-09-25 22:57 Updated by: alienvalkyrie
  • New Ticket "generate_packets.py: Replace unfill with bit-copy/move" created
2022-09-26 22:04 Updated by: alienvalkyrie
  • Résolution Update from Aucun to Accepted
2022-09-28 22:25 Updated by: alienvalkyrie
  • État Update from Ouvert to Atteints
  • Résolution Update from Accepted to Fixed

Modifier

Please login to add comment to this ticket » Connexion