bool player_has_color() returning NULL

• Rapporteur: cazfi
• Propriétaire: cazfi
• Type: Bogues
• État: Atteints
• Composant: Client common
• Jalon: 3.0.6 (atteints)
• Priorité: 5 - moyen
• Sévérité: 5 - moyen
• Résolution: Fixed
• Fichier: 4

Détails

player_has_color() has "fc_assert_ret_val(pplayer != NULL, NULL);" while it's supposed to return boolean.

Found by attempting c2x standards build with gcc-13.

Ticket History (3/7 Histories)

2022-12-18 23:45 Updated by: cazfi

• New Ticket "bool player_has_color() returning NULL" created

2022-12-19 00:31 Updated by: cazfi

• File 0042-Return-FALSE-instead-of-NULL-from-player_has_color.patch (File ID: 11155) is attached

2022-12-19 00:31 Updated by: cazfi

• File 0030-Return-FALSE-instead-of-NULL-from-player_has_color.patch (File ID: 11156) is attached

2022-12-19 00:31 Updated by: cazfi

• File 0020-Return-FALSE-instead-of-NULL-from-player_has_color.patch (File ID: 11157) is attached

2022-12-19 00:32 Updated by: cazfi

• File 0004-Return-FALSE-instead-of-NULL-from-player_has_color.patch (File ID: 11158) is attached

2022-12-19 00:32 Updated by: cazfi

• Propriétaire Update from (Aucun) to cazfi
• Résolution Update from Aucun to Accepted
• Jalon Update from (Aucun) to 3.0.6 (atteints)

Commentaire

Also S2_6 version.

2022-12-27 14:59 Updated by: cazfi

• État Update from Ouvert to Atteints
• Résolution Update from Accepted to Fixed