action_is_hostile() rework

• Rapporteur: cazfi
• Propriétaire: cazfi
• Type: Patches
• État: Atteints
• Composant: General
• Jalon: 3.2.0
• Priorité: 5 - moyen
• Sévérité: 5 - moyen
• Résolution: Fixed
• Fichier: 1

Détails

action_is_hostile() has several aspects I'd like to improve.

- It lives in unittype.c, even when it's about actions
- It's another massive switch - case, based on actres. Should be turned to a quick array lookup
- Type of the parameter needs to be checked. Both actres pointer and action pointer would likely be better than current action id

Ticket History (3/5 Histories)

2023-02-20 19:51 Updated by: cazfi

• New Ticket "action_is_hostile() rework" created

2023-02-22 08:46 Updated by: cazfi

Commentaire

Better to implement on top of #47464 than before it.

2023-03-02 20:29 Updated by: cazfi

• File 0028-Rename-action_is_hostile-as-actres_is_hostile.patch (File ID: 11752) is attached

2023-03-02 20:29 Updated by: cazfi

• Propriétaire Update from (Aucun) to cazfi
• Résolution Update from Aucun to Accepted

2023-03-04 21:29 Updated by: cazfi

• État Update from Ouvert to Atteints
• Résolution Update from Accepted to Fixed