sdl2: popup_impr_info() NULL dereference when impr has just !present reqs

• Rapporteur: cazfi
• Propriétaire: cazfi
• Type: Bogues
• État: Atteints
• Composant: SDL2-client
• Jalon: 3.0.7 (atteints)
• Priorité: 5 - moyen
• Sévérité: 5 - moyen
• Résolution: Fixed
• Fichier: 3

Détails

Clang analyzer (S3_0):

../../../../src/client/gui-sdl2/helpdlg.c:539:23: warning: Access to field 'next' results in a dereference of a null pointer (loaded from field 'pRequirementButton') [core.NullDereference]
pRequirementLabel = pStore->pRequirementButton->next;

I think this is real. pStore->pRequirementButton, set from pRequirementLabel2, might be NULL when the improvement both HAS requirements, but all of those are negated ones.

Ticket History (3/6 Histories)

2023-03-11 14:38 Updated by: cazfi

• New Ticket "sdl2: popup_impr_info() NULL dereference when impr has just !present reqs" created

2023-03-11 15:11 Updated by: cazfi

• File 0013-sdl2-Fix-help-NULL-dereference-for-improvements-with.patch (File ID: 11823) is attached

2023-03-11 15:12 Updated by: cazfi

• File 0008-sdl2-Fix-help-NULL-dereference-for-improvements-with.patch (File ID: 11824) is attached

2023-03-11 15:12 Updated by: cazfi

• File 0004-sdl-2-Fix-help-NULL-dereference-for-improvements-wit.patch (File ID: 11825) is attached

2023-03-11 15:12 Updated by: cazfi

• Propriétaire Update from (Aucun) to cazfi
• Résolution Update from Aucun to Accepted

Commentaire

Also S2_6 version included, with sdl-client handled.

2023-03-17 02:10 Updated by: cazfi

• État Update from Ouvert to Atteints
• Résolution Update from Accepted to Fixed